org.geotools.process.impl.SingleProcessFactory#checkName(Name name) returns 
always true unless name is null
-----------------------------------------------------------------------------------------------------------

                 Key: GEOT-2977
                 URL: http://jira.codehaus.org/browse/GEOT-2977
             Project: GeoTools
          Issue Type: Bug
    Affects Versions: 2.6.2
            Reporter: Matthias Lendholt
            Priority: Trivial
             Fix For: 2.6.3


Bug in equals check in row 73
currently:      if(!processName.equals(processName))
but it must be: if(!processName.equals(name))

PATCH:

Index: src/main/java/org/geotools/process/impl/SingleProcessFactory.java
===================================================================
--- src/main/java/org/geotools/process/impl/SingleProcessFactory.java   
(revision 34027)
+++ src/main/java/org/geotools/process/impl/SingleProcessFactory.java   
(working copy)
@@ -70,7 +70,7 @@
     void checkName(Name name) {
         if(name == null)
             throw new NullPointerException("Process name cannot be null");
-        if(!processName.equals(processName))
+        if(!processName.equals(name))
             throw new IllegalArgumentException("Unknown process '" + name 
                     + "', this factory knows only about '" + processName +  
"'");
     }


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to