Cool - can you raise a Jira issue and attach a patch?
Jody

On 29/04/2010, at 11:00 PM, Charles Ballance wrote:

> While redoing the FidFilterImpl, i noticed the common pitfall of not 
> using Logging properly, ie.,
> not using
> if( LOGGER.isLoggable(Level.FINEST) ) {
>   do log...
> }
> For calls where one constructs the logger's arguments dynamically(most 
> often string concatenation).
> This forces the jvm to do extra work prior to the function call.
> 
> This issue exists in other Filter implementations and needs to be neutered.
> See:
> LogicFilterImpl
> LikeFilterImpl
> GeometryFilterImpl
> AttributeExpressionImpl
> 
> ------------------------------------------------------------------------------
> _______________________________________________
> Geotools-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geotools-devel


------------------------------------------------------------------------------
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to