Hi Jody, I have updated the patches for both GEOT-3039 and GEOT-3040, by adding test cases. Please, let me know if you are ok with them.
Regards, Daniele On Mon, Apr 26, 2010 at 9:32 AM, Jody Garnett <jody.garn...@gmail.com>wrote: > Cool - so if you would like to create a test case for your other two > patches I would be pleased to see them accepted. > > Jody > > On 26/04/2010, at 5:07 PM, Daniele Romagnoli wrote: > > Hi, > > > On Sat, Apr 24, 2010 at 12:43 AM, Jody Garnett <jody.garn...@gmail.com>wrote: > >> I am fine with you making the changes Daniele; in general I rejected your >> patches because they did not have test cases. >> >> I only helped on 3041 to show you that the methods could be added without >> adding a dependency on commons-io - I am still waiting to hear if that meets >> your needs? >> > > Taking a look on my gmail account, I think it never sent my reply about > your fixes (don't know why... maybe connection lost while sending the > reply). Basically, your fixes were good... I have refactored some of my > methods to work on IOFileFilter built on top of FileNameFilter returned by > your methods. > Thanks, > > Daniele > > >> >> Jody >> >> On 23/04/2010, at 6:46 PM, Daniele Romagnoli wrote: >> >> Hi list, >> any news on these topics? Jody already assisted me on points 3,4,5,6. >> (Thanks) >> What about ensureNonNull, ReferencedEnvelope and checkEmptySourceRegion? >> I see Martin was the mantainer of the gt-metadata module (The one where I >> would like to add the ensureNonNull method). >> Could I directly work on http://jira.codehaus.org/browse/GEOT-3039 and >> add the method to that module? >> Please, let me know. >> >> Regards, >> Daniele >> >> >> On Tue, Apr 13, 2010 at 11:06 AM, Daniele Romagnoli < >> daniele.romagn...@geo-solutions.it> wrote: >> >>> Hi again, >>> I'm setting up some JIRAs to handle some minor changes I would like to >>> propose in order to arrange some common utility methods. Here below, you >>> will find a summary with: Method, brief description, destination module, >>> related JIRA (with attached patch). >>> >>> 1) public static void ensureNonNull(final String name, final Object >>> object) >>> - Makes sure that an argument is non-null. Throws a NullPointerException >>> leveraging on ErrorKeys.NULL_ARGUMENT_$1 >>> - could be moved on gt-metadata ---> org.geotools.util.Utilities class >>> - JIRA: http://jira.codehaus.org/browse/GEOT-3039 >>> >>> 2) public static boolean checkEmptySourceRegion(final ImageReadParam >>> readParameters, final Rectangle dimensions) >>> - Checks that the provided dimensions, when intersected with the source >>> region used by the provided ImageReadParam instance, does not result in an >>> empty rectangle. Finally, in case the region intersection is not empty, set >>> it as new source region for the ImageReadParam. >>> - could be moved on gt-coverage ---> >>> org.geotools.resources.coverage.CoverageUtilities >>> - JIRA: http://jira.codehaus.org/browse/GEOT-3040 >>> >>> 3) public static String checkDirectory(String directoryPath) >>> - Checks that the provided directory path refers to an existing/readable >>> directory. >>> - could be moved on gt-main ---> org.geotools.data.DataUtilities >>> - JIRA: http://jira.codehaus.org/browse/GEOT-3041 >>> >>> 4) public static boolean checkFileReadable(final File file, final Logger >>> logger) >>> - Checks that a File is a real file, exists and is readable. >>> - could be moved on gt-main ---> org.geotools.data.DataUtilities >>> - JIRA: http://jira.codehaus.org/browse/GEOT-3041 >>> >>> 5) public static IOFileFilter excludeFilters(final IOFileFilter >>> inputFilter, IOFileFilter... filters) >>> - Returns a IOFileFilter obtained by excluding from the first input >>> filter argument, the additional filter arguments. >>> - could be moved on gt-main ---> org.geotools.data.DataUtilities >>> - JIRA: http://jira.codehaus.org/browse/GEOT-3041 >>> >>> 6) public static IOFileFilter includeFilters(final IOFileFilter >>> inputFilter, IOFileFilter... filters) >>> - Returns a IOFileFilter obtained by adding to the first input filter >>> argument, the additional filter arguments. >>> - could be moved on gt-main ---> org.geotools.data.DataUtilities >>> - JIRA: http://jira.codehaus.org/browse/GEOT-3041 >>> >>> 7) public ReferencedEnvelope(final GeographicBoundingBox geoBBox) >>> - Creates a new envelope from a {...@link GeographicBoundingBox} (Using >>> WGS84 as CRS). >>> - could be added as a new constructor in gt-api ---> >>> org.geotools.geometry.jts.ReferencedEnvelope >>> I already have a patch for this but before to open a JIRA, I'm asking if >>> could be possible to add this new constructor to the api module or, being it >>> a critical core module, it isn't possible at all and I should opt for an >>> utilities method. >>> (Note GeographicBoundingBox comes from >>> org.opengis.metadata.extent.GeographicBoundingBox) >>> >>> Note that 3,4,5,6 requires adding commons-io as a dependency. Do you see >>> any issue with this? >>> >>> Please, let me know; feedbacks are welcome. Moreover, if you think I can >>> go on with some of them by myself, please let me know. >>> Regards, >>> Daniele >>> >>> -- >>> ------------------------------------------------------- >>> Eng. Daniele Romagnoli >>> Software Engineer >>> >>> GeoSolutions S.A.S. >>> Via Carignoni 51 >>> 55041 Camaiore (LU) >>> Italy >>> >>> phone: +39 0584983027 >>> fax: +39 0584983027 >>> mob: +39 328 0559267 >>> >>> >>> http://www.geo-solutions.it >>> >>> ------------------------------------------------------- >>> >>> >> >> >> -- >> ------------------------------------------------------- >> Eng. Daniele Romagnoli >> Software Engineer >> >> GeoSolutions S.A.S. >> Via Carignoni 51 >> 55041 Camaiore (LU) >> Italy >> >> phone: +39 0584983027 >> fax: +39 0584983027 >> mob: +39 328 0559267 >> >> >> http://www.geo-solutions.it >> >> ------------------------------------------------------- >> >> >> ------------------------------------------------------------------------------ >> _______________________________________________ >> Geotools-devel mailing list >> Geotools-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >> >> >> >> >> ------------------------------------------------------------------------------ >> >> _______________________________________________ >> Geotools-devel mailing list >> Geotools-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >> >> > > > -- > ------------------------------------------------------- > Eng. Daniele Romagnoli > Software Engineer > > GeoSolutions S.A.S. > Via Carignoni 51 > 55041 Camaiore (LU) > Italy > > phone: +39 0584983027 > fax: +39 0584983027 > mob: +39 328 0559267 > > > http://www.geo-solutions.it > > ------------------------------------------------------- > > > > > ------------------------------------------------------------------------------ > > _______________________________________________ > Geotools-devel mailing list > Geotools-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > > -- ------------------------------------------------------- Eng. Daniele Romagnoli Software Engineer GeoSolutions S.A.S. Via Carignoni 51 55041 Camaiore (LU) Italy phone: +39 0584983027 fax: +39 0584983027 mob: +39 328 0559267 http://www.geo-solutions.it -------------------------------------------------------
------------------------------------------------------------------------------
_______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
