Perhaps I see; you are caching both a set of FeatureId and a set of String?
It is more that you have provided an entire new implementation; rather then a
patch which would show us what you have changed (and by extension what you are
talking about).
Jody
On 30/04/2010, at 11:49 PM, Jody Garnett wrote:
> So here is where I am confused; I am keen for more performance....
> but what is the difference here? what has changed.... are you changing the
> Set inside the Id filter?
> was it like a TreeSet and now a HashSet?
>
> Jody
>
> On 30/04/2010, at 11:20 PM, Charles Ballance wrote:
>
>> Jody, I've updated the Jira issue. Don't know if code snippets are wanted,
>> this is taken from an example in demo.
>>
>> Usage:
>> FeatureCollection getCollectionForFeature( Set<FeatureId> fids,
>> FeatureSource featureSource ) throws Exception {
>> FilterFactory2 ff = CommonFactoryFinder.getFilterFactory2(
>> GeoTools.getDefaultHints() );
>> Filter filter = ff.id( fids );
>> return featureSource.getFeatures( filter );
>> }
>>
>> FeatureCollection iteration is O(n). New one is O(logn).
>>> Hi Charles - we have a user list for questions; this list is really focused
>>> on those working on geotools.
>>>
>>> So your email *just* makes it over the bar - now your attached code does
>>> not mean anything to me - what is it and how is it different from
>>> our usual FidFilterImpl?
>>>
>>> Jody
>>>
>>> On 29/04/2010, at 10:46 PM, Charles Ballance wrote:
>>>
>>>
>>>> I'm working on making a Swing application w/geotools. As such, I am
>>>> running
>>>> across various performance issues.
>>>> I am dynamically updating a layer's features(coloring features) and cannot
>>>> iterate over the
>>>> FeatureSource's FeatureCollection when applying the filter for
>>>> Set<FeatureId> without the
>>>> attached code.
>>>>
>>>> Would somebody check it out and commit if appropriate.
>>>>
>>
>
------------------------------------------------------------------------------
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel