Jody Garnett ha scritto:
> I was more meaning that I updated that page with your change in mind.
> Please review.
Looks good, did just some minor edits.
Aside... this style of coding:
if(...) {
...
}
else {
}
is afaik against the Java coding conventions, that do suggest this instead:
if(...) {
...
} else {
...
}
E.g., straight from ArrayList.java:
if (o == null) {
for (int i = 0; i < size; i++)
if (elementData[i]==null)
return i;
} else {
for (int i = 0; i < size; i++)
if (o.equals(elementData[i]))
return i;
}
or from Collections.java
if (size < FILL_THRESHOLD || list instanceof RandomAccess) {
for (int i=0; i<size; i++)
list.set(i, obj);
} else {
ListIterator<? super T> itr = list.listIterator();
for (int i=0; i<size; i++) {
itr.next();
itr.set(obj);
}
}
(btw, it seems Java own code does not add parenthesis for one
liner blocks inside ifs and loops)
> Sphinx is not going to be used until we have a plan and a talk with
> frank or Justin about deployment. Until then the wiki us our docs.
Ok :-)
Cheers
Andrea
--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.
------------------------------------------------------------------------------
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
