Micheal please check the issue for an updated patch I have separated out a MapViewport holding the bounds+crs for the map. The map does retain an internal MapViewport for use in an interactive session. But I can understand your need to keep one on the side for background rendering; or to have many of them for rendering into tiles.
I have two more hurdles: - DefaultMapContext - I could make this use a Map internally - GTRender - can be updated to have a setMap method; and update the implementations to use the Map Jody On 12/06/2010, at 6:53 PM, Michael Bedward wrote: > Hi Jody, > > A few comments / queries to get started (sorry for the bitty nature of > what follows but I'm multi-mutli-tasking this weekend :) > > First up - it's so good to see this becoming reality. It's going to > make many things much easier and cleaner. > > In the Layer class, are the the methods for firing selected / > deselected events only there to prevent compilation errors in > DefaultMapContext at the moment ? I remember we talked about removing > the notion of 'selected' from layers. > > A small typo with the dispose method name (dispoose :) > > In the Map class, why are there separate crs and bounds fields. I > recall (I think) that we decided to hold both the CRS and bounds in a > single ReferencedEnvelope in the existing DefaultMapContext to avoid > error / confusion. > > Further on this point, I confess I'm still unsure about the merits of > Map objects storing _any_ viewport data. I lean towards that being the > responsibility of display classes. I would like the ability to share > a single Map object between two or more JMapPanes (for example) with > bounds specific to each pane. > > Michael > > PS. for little things like dispose method name, would you prefer I > tell you, or just fix them on the branch, or provide a patch ? ------------------------------------------------------------------------------ ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
