Hmm, one parameter for layout AND data access ? However, looking at geotools as a library, it is very "unlucky" to introduce a new parameter passing mechanism. This is surly not what a developer expects and will cause confusion. And one has to take care to clean up all the values in the environment properly (specially in the case of exceptions) to avoid nasty side effects.
A proposal to bring it under an umbrella. Andrea, if you implement the parameter passing using the query objects and additionally, if a VT misses a parameter, you look up into the environment. This has an additional effect, giving the caller the possibility to override environment settings. Too make it clear, we offer both possibilities, giving the priority to parameters passed in the expected manner. If the parameter is not passed, we look up with EnvFunction. This should work for all of us. What do you think ? Quoting Andrea Aime <[email protected]>: > Michael Bedward ha scritto: >> On 23 June 2010 17:21, Andrea Aime wrote: >>> Votes please :-) >>> >> >> I like the env function approach over yet more hints, but I'm >> probably biased :) > > Hmmm... the sponsor just told me he wants to have the sld param > expansion and the sql view paths separate so that he does not have > to think about not repeating the same param name in sql views and sld. > > Makes sense, you might not remember all the params that have already > been put in the sld's around when creating a new view, and vice versa. > > Cheers > Andrea > > -- > Andrea Aime > OpenGeo - http://opengeo.org > Expert service straight from the developers. > > ------------------------------------------------------------------------------ > ThinkGeek and WIRED's GeekDad team up for the Ultimate > GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the > lucky parental unit. See the prize list and enter to win: > http://p.sf.net/sfu/thinkgeek-promo > _______________________________________________ > Geotools-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geotools-devel > ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program. ------------------------------------------------------------------------------ ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
