Jody Garnett ha scritto: > Sounds fine andrea; if possible I would like to use the data module > (for something!) or kill it. I figure it is the same purpose as the > jdbc module (helper classes, root implementations and so forth). > > At least for the first cut do what we did with AbstractDatastore and > rely on the test cases in shapefile datastore to cover the base class. > > You may want to teach the shapefile factory to do the actual creation > (so you can reuse the param definition). It already has the task of > select the best implementation based on parameters so it is a good > fit. I know it is a bit rude making the factory smart (ie have logic) > but it does beat people expecting to call DataStoreFinder and should > be less work for you.
Here is a jira and a patch for your reviewing pleasure: http://jira.codehaus.org/browse/GEOT-3233 (suggestion, the patch is big because the directory module contained a lot of dead gml data, just look for the bits in modules/library/data, modules/plugin/shapefile) Cheers Andrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------------ The Palm PDK Hot Apps Program offers developers who use the Plug-In Development Kit to bring their C/C++ apps to Palm for a share of $1 Million in cash or HP Products. Visit us here for more details: http://p.sf.net/sfu/dev2dev-palm _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
