JDBCDataStore.finalize() logs inappropriately
---------------------------------------------

                 Key: GEOT-3272
                 URL: http://jira.codehaus.org/browse/GEOT-3272
             Project: GeoTools
          Issue Type: Improvement
          Components: data jdbc
            Reporter: Dustin Parker
            Priority: Trivial


I believe this is due to the interaction between JDBCDataStore.finalize() and 
JDBCDataStore.dispose(); the latter will check if the data source is a 
ManageableDataSource. If it's not managable by GT, no state will change even if 
dispose() is called. However, finalize() doesn't make the same check before 
logging. Either GeoServer should wrap JNDI data sources with a NOP close() or 
GT needs to check before logging this warning (or have dispose() set dataSource 
= null unconditionally)

Attaching a small patch against trunk

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to