I am not up to speed on the discussion; although I have been trying to catch up 
on Jira.

I did expect some changes to XPathPropertyAccessor - but only on trunk as you 
indicated (this was the subject of the performance discussion prior to foss4g). 
Checking ... GEOT-3066 is correct. If you look at the first comment for that 
Jira it does indicate that the extent of the changes ... including 
XPathPropertyAccessorFactory.

Jody

On 20/10/2010, at 9:58 AM, Justin Deoliveira wrote:

> I was reviewing the commit logs today and shocked to see that recent changes 
> revolving around property access and the feature model are being committed to 
> the stable branch?
> 
> I am also quite confused by the commit logs. For instance, I was recently 
> asked to review a patch on http://jira.codehaus.org/browse/GEOT-3066. I 
> looked it over and since it only contained files in the app-schema modules i 
> did not really have much to say. But then looking at the commit that occurred:
> 
> Author: NielsCharlier
> Date: 2010-10-19 00:01:43 -0700 (Tue, 19 Oct 2010)
> New Revision: 36280
> 
> Modified:
>   
> branches/2.6.x/modules/extension/xsd/xsd-core/src/main/java/org/geotools/xml/XPathPropertyAccessorFactory.java
>   
> branches/2.6.x/modules/extension/xsd/xsd-core/src/test/java/org/geotools/xml/XPathPropertyAcessorTest.java
>   
> branches/2.6.x/modules/library/main/src/main/java/org/geotools/filter/AttributeExpressionImpl.java
>   
> branches/2.6.x/modules/library/main/src/main/java/org/geotools/filter/FidFilterImpl.java
>   
> branches/2.6.x/modules/library/main/src/main/java/org/geotools/filter/expression/PropertyAccessors.java
>   
> branches/2.6.x/modules/unsupported/app-schema/app-schema/src/main/java/org/geotools/data/complex/config/AppSchemaDataAccessConfigurator.java
>   
> branches/2.6.x/modules/unsupported/app-schema/app-schema/src/main/java/org/geotools/filter/expression/FeaturePropertyAccessorFactory.java
>   
> branches/2.6.x/modules/unsupported/app-schema/app-schema/src/test/java/org/geotools/filter/expression/FeaturePropertyAccessorTest.java
>   
> branches/2.6.x/modules/unsupported/app-schema/app-schema/src/test/resources/test-data/TimeSeriesTest_properties.xml
> Log:
> provides error reporting for invalid columns in app-schema mapping file, see 
> GEOT-3066
> 
> Ummmmm.... am I missing something here?
> 
> Aside from the commits being way off from the jira issue I thought it was 
> discussed before in both jira and on the developer list that this change was 
> only going to be made on the trunk/unstable branch and not on 2.0.x which is 
> our current stable branch.
> 
> Is there something I am missing?
> 
> -- 
> Justin Deoliveira
> OpenGeo - http://opengeo.org
> Enterprise support for open source geospatial.
> 
> ------------------------------------------------------------------------------
> Download new Adobe(R) Flash(R) Builder(TM) 4
> The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly 
> Flex(R) Builder(TM)) enable the development of rich applications that run
> across multiple browsers and platforms. Download your free trials today!
> http://p.sf.net/sfu/adobe-dev2dev_______________________________________________
> Geotools-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geotools-devel

------------------------------------------------------------------------------
Download new Adobe(R) Flash(R) Builder(TM) 4
The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly 
Flex(R) Builder(TM)) enable the development of rich applications that run
across multiple browsers and platforms. Download your free trials today!
http://p.sf.net/sfu/adobe-dev2dev
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to