On Wed, Dec 15, 2010 at 1:01 AM, Jody Garnett <[email protected]> wrote: > On 15/12/2010, at 9:39 AM, Walter Deane wrote: > >> Hello Andrea, >> >> The big change that I am looking at is the fact that JDBCDatastore is final >> now, so I have altered VersionedNGPostgisDataStore to act as a wrapper >> directly for the JDBCDataStore and have moved some of the bits from the >> Wrapped class there and am trying to eliminate the need for the >> wrapped/wrapping classes entirely. Not sure at what point this approach >> might cause problems but if any pop up I should see them in the next day as >> i get deeper. I am trying to keep as close your existing structure as >> possible so that it will fit into the geotools codebase and be easier for >> everyone to follow. >> > > Are you extending ContentDatastore a second time then? I don't like the idea > of duplicating state information as it caused us some grief previously with > the AbstractDataStore implementation.
Doing a wrapper is unavoidable, and the wrapper will have to keep some state as the view of the feature types for the outside world is different from the actual structure, so the wrapper has to keep those mappings and the "public" feature types as its state. However I guess one can get away by mostly implementing the DataStore interface directly and do delegations to the wrapped store Cheers Andrea ----------------------------------------------------- Ing. Andrea Aime Senior Software Engineer GeoSolutions S.A.S. Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584962313 fax: +39 0584962313 http://www.geo-solutions.it http://geo-solutions.blogspot.com/ http://www.linkedin.com/in/andreaaime http://twitter.com/geowolf ----------------------------------------------------- ------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
