Hi all, id like to ask for opinion/questions regarding current wms-ext module version negotiation ( when executing GetCapabilities request for an example )
Currently the negotiateVersion() inside AbstractOpenWebService class doesnt check if the version parameter is included inside request. Instead it goes from highest version and checks if the server returns valid getCapabilities response for that version. If response is not valid , it continues with lower versions until valid response is received. If version parameter is supplied with request we should go on and try to issue getCaps with that version first. If we dont get valid response we should then or throw exception or go on and try to find valid version, like module is currently working. This problem causes WMS cascading module to break if cascading WMS servers by default have v1.3.0 (as we cant select service version by using version parameter http://jira.codehaus.org/browse/GEOT-3361) Id like to hear opinions if this is the right thing to do here. I made a temporary patch that checks if the version parameter is supplied and uses supplied version if its valid. What I dont like is that I manually parse request and check for version param. Is there a better (geotools) way that checks/validate existence of version parameter inside URL? I noticed that there is some URL parsing inside AbstractRequest class (which is then implemented by AbstractGetCapabilitiesRequest, and then extended by inner class GetCapsRequest inside WMS1_0_0 class) Would that be the right way to go? Thank you & regards, -- Ivan Grcic ------------------------------------------------------------------------------ Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
