I have created a ticket for this and will attache a patch for review in a
few minutes. I have since found other instances of this assumption. I will
add all the findings to that ticket:
http://jira.codehaus.org/browse/GEOT-3485
I would like a review from Justin or Andrea before I commit to ensure that
they agree with the changes.
Jesse
On Tue, Mar 29, 2011 at 1:58 PM, <[email protected]> wrote:
> Many db systems retrieve the records in the inserting order if no order by
> is given. But this is not part of any sql standard, the order of the records
> is not guaranteed unless an order by clause is present.
>
> The test relies on a false assumption and should be rewritten. This can be
> done by checking the size of the result and checking for containment of each
> record. The JDBC class is ResultSet, sets are always unordered.
>
> Cheers
> Christan
>
>
>
> Quoting Jesse Eichar <[email protected]>:
>
> Hi,
>> currently the testGetFeatureReader in JDBCDatastoreTest assumes that the
>> features are retrieved from the database in a certain order and if the
>> database does not return the features in the same order as they are
>> inserted
>> the test fails.
>>
>> My question:
>>
>> Is there a rule that states that features must be returned from a feature
>> source in a certain order or could this test be less strict with regards
>> to
>> ordering?
>>
>> Jesse
>>
>>
>
>
> ----------------------------------------------------------------
> This message was sent using IMP, the Internet Messaging Program.
>
>
>
------------------------------------------------------------------------------
Enable your software for Intel(R) Active Management Technology to meet the
growing manageability and security demands of your customers. Businesses
are taking advantage of Intel(R) vPro (TM) technology - will your software
be a part of the solution? Download the Intel(R) Manageability Checker
today! http://p.sf.net/sfu/intel-dev2devmar
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
