Ah sorry - I was reading from the patch and misunderstood (I tried patching the source but had problems with the format again).
In that case I think it's hunky-dory - much better than before :) Michael On 1 April 2011 20:34, Jody Garnett <[email protected]> wrote: > The warning is less aggressive than that ... > It is only issued when: > 1. a geometry is being added > 2. it is getting the default CRS > 3. and the defaultCRS has not been set yet (well is null) > For the message in the build method; it is only enountered when > defaultGeomtry was set to something that was not added as a Geometry at all > (not even sure how this can happen). > -- > Jody Garnett > > On Friday, 1 April 2011 at 7:26 PM, Michael Bedward wrote: > > HI Jody, > > Just had a quick look at the patch. The javadocs are much better and I > think the logger is a good idea. > > My only query is about the logger message in the buildFeatureType > method. It's at warning level but should it be ? Perhaps just info ? > Or maybe instead, log a message when the geometry attribute is added > and is getting the default CRS. > > What do you think ? > > Michael > > On 1 April 2011 19:31, Jody Garnett <[email protected]> wrote: > > I have added a warning to SimpleFeatureTypeBuilder, and a bunch of javadocs > with code examples. > It seems justin is busy in release mode, Micheal could I ask you to review > the patch for: https://jira.codehaus.org/browse/GEOT-3489 > > > -- > Jody Garnett > > ------------------------------------------------------------------------------ Create and publish websites with WebMatrix Use the most popular FREE web apps or write code yourself; WebMatrix provides all the features you need to develop and publish your website. http://p.sf.net/sfu/ms-webmatrix-sf _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
