Additional Filters utility methods
----------------------------------

                 Key: GEOT-3513
                 URL: http://jira.codehaus.org/browse/GEOT-3513
             Project: GeoTools
          Issue Type: Sub-task
          Components: core filter
    Affects Versions: 8-M0
            Reporter: Jody Garnett


Second feedback on a lot of the utility methods:
- they are static but not public
- they are static and refer to a static FilterFactory

Option A) make them public and non static - code example:
{code}
   Filters filters = new Filters( filterFactory ); // null would use the global 
default
   filters.addFilter( baseFilter, newFilter )
{code}

Option B) have each method accept a CommonFactoryFinder
{code}
   Filters.addFilter( filterFactory, baseFilter, newFilter);
{code}

Option C) Make the methods public static, and implement each with a lookup to 
CommonFactoryFinder internally
{code}
   Filter.addFilter( baseFilter, newFilter );
{code}

In this case I do not want to leave well enough alone and give up on people 
using their own FilterFactory. The application schema people do use custom 
filter factories in order to throw exceptions when a propertyName is invalid.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Forrester Wave Report - Recovery time is now measured in hours and minutes
not days. Key insights are discussed in the 2010 Forrester Wave Report as
part of an in-depth evaluation of disaster recovery service providers.
Forrester found the best-in-class provider in terms of services and vision.
Read this report now!  http://p.sf.net/sfu/ibm-webcastpromo
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to