This proposal was put up on the 17th:
- http://docs.codehaus.org/display/GEOTOOLS/Describe+Function+with+FunctionName
A lot of work was done; and added to trunk; with a very small patch to enable
the api change:
- https://jira.codehaus.org/browse/GEOT-3519
Thanks to Andrea for talking this one over with me; the long and short of it
was that the api change was fine; but Andrea would like to extend FunctionName
to be more useful at a later time. Changing FunctionName goes beyond what I had
time for.
BEFORE
public interface Function extends Expression { String getName();
List<Expression> getParameters(); Literal getFallbackValue(); } interface
FilterFactory { .... /** function name */ FunctionName functionName(String
name, int nargs); ... } class FunctionFinder { .. }
AFTER:
public interface Function extends Expression { String getName(); FunctionName
getFunctionName(); List<Expression> getParameters(); Literal
getFallbackValue(); } interface FilterFactory { .... /** function name */
FunctionName functionName(String name, int nargs); FunctionName
functionName(String name, int nargs, List<String> argNames); ... } class
FunctionFinder { List<FunctionName> getFunctionNames() .. }
The proposal is focused on adding Function.getFunctionName() method, and
providing a helper method in FunctionFinder to replace some boiler plate code
used in the user guide.
The functionName method added to FilterFactory is just correcting a mistake,
and is not considered an change of data structure. The method is used to create
a FunctionName for the FilterCapabilities data structure. Previously the only
way to do this (and include argument names) was to code up your own, or use
FunctionNameImpl constructor directly.
--
Jody Garnett
------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network
management toolset available today. Delivers lowest initial
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
