Hi Andrea, Thanks for your reply. To respond to your questions/remarks.
1. Yes, XML parsers will need to be updated too, that will be one of the last steps. We were currently only thinking of providing the back-end support. I will add it to the to-do list though.
2. Only methods should be added to the filterfactory. All existing method should stay.
3. I will do the extra check to avoid collection wrappers if not necessary. Regards Niels On 12/05/11 20:15, Andrea Aime wrote:
On Thu, May 12, 2011 at 6:25 AM, Niels<[email protected]> wrote:http://docs.codehaus.org/display/GEOTOOLS/Support+Multi-Valued+Attributes+in+Filter+Comparison+OperatorsI don't have the Filter 2.0 specification handy but afaik you'll also have to update the OGC interfaces for those filters to add the matchAction attribute and modify the XML encoders and parsers (both old and new generation, sorry) to handle the matchAction? The proposal does not show that part. A little detail, in the code example it should be matchAction, not matchCase? As for the performance perspective, it would be better to avoid creating the collectoin wrappers as filters are evaluated repeatedly for each feature in the rendering, it's not uncommon to render hundreds of thousands, up to millions features in a simple feature rendering situation. So the code should be preceded, imho, with a check like: if(!(object1 instanceof Collection)&& !(object2 instanceof Collection)) { return evaluateInternal(value1, value2); } right after the collection wrapping step. The changes to the filter factory... you will be preserving backwards compatible methods right? I did not follow the whole discussion but an untyped kvp is painful to use, it's one of the reasons why working with JAI is painful (look ma, just one factory method for all operations! And then they realized it was hard to use and made statically typed *Descriptor classes to make it code complete and autodoc friendly). Cheers Andrea
-- *Niels Charlier* Software Engineer CSIRO Earth Science and Resource Engineering Phone: +61 8 6436 8914 Australian Resources Research Centre 26 Dick Perry Avenue, Kensington WA 6151
------------------------------------------------------------------------------ Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay
_______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
