Cool thanks. Sorry I came off harsh in my response, the feedback is
appreciated. Getting back to the topic I did find it was hard to come up
with a nice convenient method to call to create the function name because
there are a number of options other than name and type, like min/max,
required, etc..
But yeah a DataUtilities.type() like method where we can pass in a concise
string to encode all the options should work nicely. I will take a crack at
adding such a method when i commit the initial api changes. And can try to
help out with the mass function name update on the weekend as well.
On Tue, May 24, 2011 at 7:16 PM, Jody Garnett <jody.garn...@gmail.com>wrote:
> Hey Justin:
>
> Sorry you are over time on this one; you do have 3 positive votes on the
> issue; so near as I can tell you can start committing.
> Andrea can we talk on the weekend about updating the existing functions?
>
> --
> Jody Garnett
>
> On Wednesday, 25 May 2011 at 2:30 AM, Justin Deoliveira wrote:
>
>
>
> On Tue, May 24, 2011 at 8:55 AM, Jody Garnett <jody.garn...@gmail.com>wrote:
>
> And why not be explicit directly in code? An argument has a name and a
> type directly... what would the point of storing them in a property file?
> Only thing i can think of is for i18n purposes.
>
>
> The point is to quickly get gt-main functions back; without going through
> all of them again. Better then hard coding the information that an argument
> named "geom" defaults to Geometry.class?
>
> I really don't see how something like:
>
> functionName("geom")
>
> is much of a time saver over functionName("geom", Geometry.class)
>
> But sure, i am not against such a utility. My vote would be a static method
> on one of the function base classes.
>
> However mass updating all the functions so that they properly declare
> argument names and types is outside of my scope of work here... my goal for
> now is just to update the api. If people feel that updating all the
> functions is a blocker for this proposal to go through then unfortunately i
> won't be able to see it through as I am already running over the time
> estimated for this task.
>
>
> Jody
>
>
>
>
>
> --
> Justin Deoliveira
> OpenGeo - http://opengeo.org
> Enterprise support for open source geospatial.
>
>
>
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
vRanger cuts backup time in half-while increasing security.
With the market-leading solution for virtual backup and recovery,
you get blazing-fast, flexible, and affordable data protection.
Download your free trial now.
http://p.sf.net/sfu/quest-d2dcopy1
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
