On Sun, May 29, 2011 at 7:01 PM, Justin Deoliveira <[email protected]> wrote:
>> could have been used like:
>> name("Concatenate", p("result", String.class), p("text", String.class,
>> 2));
>> could have been used instead of:
>> functionName("Concatenate", "result:String", "text:String:2,");
>>
>> A bit longer but safer.
>
> Yeah I am fine either way. The original patch was written in this way but
> then it was brought up that a more concise syntax would be nice. There is a
> regex that validates the string passed in... apparently it is not being
> tough enough.

Oh it is, that's exactly why the build was breaking. But one has to build
with tests in order to see the error ;-)

Cheers
Andrea


-- 
-------------------------------------------------------
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054  Massarosa (LU)
Italy

phone: +39 0584 962313
fax:      +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-------------------------------------------------------

------------------------------------------------------------------------------
vRanger cuts backup time in half-while increasing security.
With the market-leading solution for virtual backup and recovery, 
you get blazing-fast, flexible, and affordable data protection.
Download your free trial now. 
http://p.sf.net/sfu/quest-d2dcopy1
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to