You got it right. In that case we would use a featureid. Let us relax that constraint so someone can make a Set<ResourceId>.
-- Jody Garnett On 26/10/2011, at 5:07 PM, Mark Leslie <mrk.les...@gmail.com> wrote: > In taking the patch for a spin, we've found some test failures in gt-xsd-fes. > > testParseId fails because the xml snippet being parsed contains a > fes:ResourceId with no version attribute. As per spec, this is > acceptable, but the ResourceIdImpl requires a Version or date range. > I have no problem with requiring a version, but we need some default > behaviour in the case where it's not provided. The spec seems to be > silent on the matter, but my preference is to use LAST as the default. > > Does this make sense, or am I coming at the problem from the right side? > > > On a side note, GeoGIT proved no trouble and I now have a resourceid > branch in my fork with the few changes needed. Will worry about a > pull request once these issues have been killed. > > -- > Mark > > > On 26 October 2011 01:36, Gabriel Roldan <grol...@opengeo.org> wrote: >> I like it. >> I don't expect it to be much of a trouble for GeoGit. What we'll need to >> review is the usage on the wfs2 versioning branch. >> As for GeoGit, the main addition is ability to mix attribute/spatial query >> with dataset history, instead of just one or the other through ResourceId, >> which is much welcomed. >> I'm looking forward to work on it (as I'd have to to update the wfs2-v >> branch). >> Cheers, >> Gabriel >> >> On Tue, Oct 25, 2011 at 4:28 AM, Jody Garnett <jody.garn...@gmail.com> >> wrote: >>> >>> Thanks for the review Mark. >>> I will check test cases again tomorrow (mostly in the xml bindings) and >>> then I am ready to commit. >>> I would kind of like feedback from Gabriel (I have already done everything >>> he indicated was required; but an extra pair of eyes would be good). >>> -- >>> Jody Garnett >>> >>> On Tuesday, 25 October 2011 at 4:01 PM, Mark Leslie wrote: >>> >>> The code examples make things clearer :) I haven't managed to apply >>> the patch to my local and see what the damage would be to GeoGIT, but >>> that's still on my list. I expect nothing scary in that regard, but >>> will let you know when I get that done. >>> >>> -- >>> Mark Leslie >>> Geospatial Software Architect >>> LISAsoft >>> >>> ------------------------------------------------------------- >>> Ph: +61 2 8570 5000 Fax: +61 2 8570 5099 Mob: +61 >>> Suite 112, Jones Bay Wharf 19-21 Pirrama Rd Pyrmont NSW 2009 >>> ------------------------------------------------------------- >>> >>> LISAsoft is part of the A2end Group of Companies >>> http://www.ardec.com.au >>> http://www.lisasoft.com >>> http://www.terrapages.com >>> >>> >>> >>> On 24 October 2011 03:07, Jody Garnett <jody.garn...@gmail.com> wrote: >>> >>> Okay the Proposal is updated ... and more importantly an updated patch is >>> provided against the Jira. >>> http://docs.codehaus.org/display/GEOTOOLS/ResouceId >>> http://jira.codehaus.org/browse/GEOT-3921 >>> This represents a good compromise; and has code examples of a few common >>> queries, diagrams etc... >>> -- >>> Jody Garnett >>> >>> On Wednesday, 19 October 2011 at 11:00 AM, Jody Garnett wrote: >>> >>> Morning: >>> I have a development team that has been working in a fork of GeoTools >>> while >>> the wfs2 and resoruceid concepts took shape. Justin has kindly merged in >>> the >>> wfs2 work (I still need to write some docs before it is done); and I have >>> now written up a proposal for the ResourceId change. >>> - http://docs.codehaus.org/display/GEOTOOLS/ResouceId >>> Since I have a development team waiting on this I will start work on >>> Monday; >>> and would like to collect any input people feel is necessary before that >>> time. The work should not take very long; there are however two options on >>> the table. >>> -- >>> Jody Garnett >>> >>> >>> >>> >>> ------------------------------------------------------------------------------ >>> The demand for IT networking professionals continues to grow, and the >>> demand for specialized networking skills is growing even more rapidly. >>> Take a complimentary Learning@Cisco Self-Assessment and learn >>> about Cisco certifications, training, and career opportunities. >>> http://p.sf.net/sfu/cisco-dev2dev >>> _______________________________________________ >>> Geotools-devel mailing list >>> Geotools-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>> >>> >>> >>> ------------------------------------------------------------------------------ >>> The demand for IT networking professionals continues to grow, and the >>> demand for specialized networking skills is growing even more rapidly. >>> Take a complimentary Learning@Cisco Self-Assessment and learn >>> about Cisco certifications, training, and career opportunities. >>> http://p.sf.net/sfu/cisco-dev2dev >>> _______________________________________________ >>> Geotools-devel mailing list >>> Geotools-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>> >> >> >> >> -- >> Gabriel Roldan >> OpenGeo - http://opengeo.org >> Expert service straight from the developers. >> ------------------------------------------------------------------------------ The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
