Hello Jody,
in updating my geoserver wfs2 versioning branch to use ResourceId from
GeoTools trunk I found what looks like an inconsistency in
ResourceIdImpl:
The following constructor should left the version be null:
public ResourceIdImpl(String fid, String featureVersion) {
this(fid, featureVersion, new Version(Version.Action.LAST));
}
like in just:
public ResourceIdImpl(String fid, String featureVersion) {
super(fid, featureVersion, null );
}
Rationale being that when both fid and version is specified, you're
asking for that specific version of the feature, which is not
necessarily the LAST one. On the same line, if the specified version
is not the last one, defaulting to Version.LAST doesn't make sense, as
there are no other possible states for that specific version. So in
that case version should be null. At least that's how jdeolive and I
interpreted the spec and wrote the versioning tests for.
Does that make sense?
Cheers,
Gabriel
--
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.
------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
