On Wed, Nov 23, 2011 at 4:20 PM, Justin Deoliveira <[email protected]> wrote: > > > On Tue, Nov 22, 2011 at 4:37 PM, Jody Garnett <[email protected]> >> I put up classes for an initial patch. >> As I copied the code across and ported I found nice clear spots for >> everything. One change here is that we need a specific subclass of >> ContentState in order to hold the Diff. It will be up to classes using the >> Diff support to make use of this implementation. > > Can we avoid the subclass, and just roll the diff into ContentState? Just > trying to keep the number of classes to a minimum, which was one of the > goals I had when I started working on ContentDataStore. Just a question, not > a strong opinion, i am not really up to speed with the work that is going > on.
I did not look into the patches yet, but agree with the sentiment, let's keep it as simple as possible (and as transparent as possible to implementors, too) Cheers Andrea -- ------------------------------------------------------- Ing. Andrea Aime GeoSolutions S.A.S. Tech lead Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 962313 http://www.geo-solutions.it http://geo-solutions.blogspot.com/ http://www.youtube.com/user/GeoSolutionsIT http://www.linkedin.com/in/andreaaime http://twitter.com/geowolf ------------------------------------------------------- ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
