Do you have an example of what you want to accomplish?
If possible I would prefer to keep those fields private (and advertise
accessors for you) so we have the option of messing with them in the future. As
an example we recently changed from a Set to a List in order to preserve the
order in which features were added.
Think about the above; but if you really need those fields to be protected then
please go ahead and apply your patch.
--
Jody Garnett
On Tuesday, 7 February 2012 at 11:26 PM, Gabriel Roldan wrote:
> Hi Jody,
>
> On Mon, Feb 6, 2012 at 10:32 PM, Jody Garnett <[email protected]
> (mailto:[email protected])> wrote:
> > It seems fine to me Gabriel; but why do you need to make those fields
> > protected? When an accessor method is available - it feels like you have a
> > subclass around or something :-)
>
> Yes, need to subclass DiffTransactionState and DiffContentFeatureWriter for
> wfs-ng in order to leverage the most possible of the ContentDataStore and
> friends in wfs-ng.
>
> >
> >
> > Note that I have taken these classes for a walk over to ContentDataStore
> > land and cleaned them up a bit.
>
> Sounds good.
>
> Cheers,
> Gabriel
> >
> > --
> > Jody Garnett
> >
> >
> > On Monday, 6 February 2012 at 6:31 PM, Gabriel Roldan wrote:
> >
> >
> >
> > > Hello,
> > >
> > > Working on wfs-ng datastore found myself in need for the following two
> > > patches. May as ask for a code review and a statement of whether it's
> > > ok to apply?
> > >
> > > <https://github.com/groldan/geotools/commit/35010c5023eba8a1b8de2d86da08384b0f035fc3>
> > >
> > > <https://github.com/groldan/geotools/commit/9a46af15dc63a94013a34cdc62a7043d67a699f7>
> > >
> > > TIA,
> > > Gabriel
> > >
> > > --
> > > Gabriel Roldan
> > > OpenGeo - http://opengeo.org
> > > Expert service straight from the developers.
> > >
> > > ------------------------------------------------------------------------------
> > > Try before you buy = See our experts in action!
> > > The most comprehensive online learning library for Microsoft developers
> > > is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> > > Metro Style Apps, more. Free future releases when you subscribe now!
> > > http://p.sf.net/sfu/learndevnow-dev2
> > > _______________________________________________
> > > GeoTools-Devel mailing list
> > > [email protected]
> > > (mailto:[email protected])
> > > https://lists.sourceforge.net/lists/listinfo/geotools-devel
> > >
> > >
> > >
> >
> >
>
>
>
> --
> Gabriel Roldan
> OpenGeo - http://opengeo.org (http://opengeo.org/)
> Expert service straight from the developers.
------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
