Hey Michael,
I haven't committed any thing yet. indeed "interactive" is misleading if in
fact they can not require any "interaction" :)
I will let Jody weigh in and can commit the change tomorrow. At any rate,
there is probably an easier/nicer way to do this but here is what i added;
diff --git
a/modules/library/render/src/test/java/org/geotools/renderer/lite/StreamingRendererDirectLayerTest.java
b/modules/library/render/src/test/java/org/geotools/renderer/lite/StreamingRendererDirectLayerTest.java
index d6f1808..78db92a 100644
---
a/modules/library/render/src/test/java/org/geotools/renderer/lite/StreamingRendererDirectLayerTest.java
+++
b/modules/library/render/src/test/java/org/geotools/renderer/lite/StreamingRendererDirectLayerTest.java
@@ -3,6 +3,7 @@ package org.geotools.renderer.lite;
import java.awt.Color;
import java.awt.Graphics2D;
import java.awt.Rectangle;
+import java.awt.Toolkit;
import java.awt.event.WindowAdapter;
import java.awt.event.WindowEvent;
import java.awt.image.BufferedImage;
@@ -125,8 +126,19 @@ public class StreamingRendererDirectLayerTest {
SwingUtilities.invokeLater(new Runnable() {
@Override
public void run() {
- TestImageFrame frame = new TestImageFrame(image, latch);
+ final TestImageFrame frame = new TestImageFrame(image,
latch);
frame.setVisible(true);
+ SwingUtilities.invokeLater(new Runnable() {
+ @Override
+ public void run() {
+ //perhaps Thread.sleep() to allow the window to
stay active for a few seconds?
+ WindowEvent e = new WindowEvent(frame,
WindowEvent.WINDOW_CLOSING);
+
Toolkit.getDefaultToolkit().getSystemEventQueue().postEvent(e);
+ }
+ });
}
});
}
Any idea about the unsupported/swing test failures? As I understand it you
run on osx as well? I am running on lion, not sure if that is what is
making the difference.
-Justin
On Thu, May 17, 2012 at 9:53 PM, Michael Bedward
<[email protected]>wrote:
> Sorry for not responding earlier Justin, Jody.
>
> I was under the impression that "interactive" allowed tests that
> require user input such as, in this case, dismissing a window after
> visual inspection.
>
> Did you commit your change ?
>
> On 18 May 2012 13:40, Justin Deoliveira <[email protected]> wrote:
> > Ok, so after patching the StreamingRendererDirectLayerTest to not wait
> for
> > user input i am able to do a successful build with extensive and
> interactive
> > tests, well for the most part. I ran into issues in the imagepyramid
> module
> > but i couldn't actually reproduce consistently. The final hiccup was in
> the
> > unsupported/swing module, a number of tests fail for me. Not sure if a
> > failure in an unsupported module should halt the release, i would think
> > not.
> >
> > On Thu, May 17, 2012 at 8:22 PM, Justin Deoliveira <[email protected]
> >
> > wrote:
> >>
> >> Hey Jody,
> >>
> >> ImageWorkerTest doesn't fail for me locally... what platform are you on?
> >> Or maybe the fix was already committed.
> >>
> >> As for the StreamingRendererDirectLayerTest it seems the test is written
> >> to hang until the user acts? If this intentional perhaps it should not
> be?
> >> Anyways, seems a straight forward fix is to just throw another event
> into
> >> the queue that closes the window. I guess we should wait to hear from
> >> Michael?
> >>
> >> On Thu, May 17, 2012 at 7:27 PM, Jody Garnett <[email protected]>
> >> wrote:
> >>>
> >>> This is a normal test (runs in all builds), the test is my fault but
> >>> for the life of me I cannot
> >>> reproduce this problem.
> >>> See previous thread on the same issue in this same ML, a user on
> >>> Windows experienced
> >>> it, but none of the devs using Linux could replicate.
> >>> I've also tried to add a blind fix, did not work either, not sure why,
> >>> it seems the
> >>> statements to clean up the geometry columns is not run.
> >>>
> >>> Just committed another variation of the cleanup, let me know if that
> >>> works any better...
> >>>
> >>> I switched back to trunk; was unable to get through the extensive tests
> >>> in the time I had for release.
> >>>
> >>> Andrea were you able to commit your ImageWorkerTest work fix to trunk?
> Or
> >>> should I rescue it.
> >>>
> >>> Jody
> >>>
> >>>
> >>>
> ------------------------------------------------------------------------------
> >>> Live Security Virtual Conference
> >>> Exclusive live event will cover all the ways today's security and
> >>> threat landscape has changed and how IT managers can respond.
> Discussions
> >>> will include endpoint security, mobile security and the latest in
> malware
> >>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> >>> _______________________________________________
> >>> GeoTools-Devel mailing list
> >>> [email protected]
> >>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
> >>>
> >>
> >>
> >>
> >> --
> >> Justin Deoliveira
> >> OpenGeo - http://opengeo.org
> >> Enterprise support for open source geospatial.
> >>
> >
> >
> >
> > --
> > Justin Deoliveira
> > OpenGeo - http://opengeo.org
> > Enterprise support for open source geospatial.
> >
> >
> >
> ------------------------------------------------------------------------------
> > Live Security Virtual Conference
> > Exclusive live event will cover all the ways today's security and
> > threat landscape has changed and how IT managers can respond. Discussions
> > will include endpoint security, mobile security and the latest in malware
> > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> > _______________________________________________
> > GeoTools-Devel mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/geotools-devel
> >
>
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
