On Thu, Aug 9, 2012 at 5:53 AM, Ben Caradoc-Davies <
ben.caradoc-dav...@csiro.au> wrote:

> Thanks, if you are the module maintainer I am more than happy for you
> review the patch.
>

Reviewed the patch, looks good but I still have some doubts about the bits
below.


>
>
>  What I'm wondering after this first look into the patch is the expected
>> axis order of the new syntax.
>> The urn form is supposed to be in lat/lon no matter what the referencing
>> hints are, if the new one is
>> going to be used for WFS I believe that also will have to respect the
>> same rules as the URN one.
>>
>
> Exactly, that is the goal of the refactoring: common behaviour through
> code reuse. The new HTTP URI form has the same lat/lon behaviour as the URN
> form.
>
> According to the javadoc, the implementation of the URN form is that
> lon/lat can be forced by setting Hints.FORCE_AXIS_ORDER_**HONORING to
> include "urn". For HTTP URI this is "http-uri". Both factories ignore this
> hint set to "http" (as recognised by HTTP_AuthorityFactory); this appears
> to be tested in URN_AuthorityFactoryTest; HTTP_URI_AuthorityFactoryTest
> does exactly the same. I say appears because gt-referencing is a jungle and
> it is often hard to tell what is going on.


GeoServer on startup forces the old http factory to work in lon/lat mode,
because that's the common axis order for
WFS 1.0, which supported the EPSG:XYWZ and the old http form.

The test checks forcing the axis order for
http://www.opengis.net/def/crs/CRS/0/84, which afaik is the only
way OGC provided to get a WGS84 in lon/lat order, which makes me thing it
shouldbe in lon/lat order
regardless of the hints you are providing. From the WMS 1.3 spec:

EXAMPLE 1
A <BoundingBox> metadata element for a Layer representing the entire Earth
in the CRS:84 Layer CRS
would be written as
<BoundingBox CRS="CRS:84" minx="-180" miny="-90" maxx="180" maxy="90">.
A BBOX parameter requesting a map of the entire Earth would be written in
this CRS as
BBOX=-180,-90,180,90.
EXAMPLE 2
A <BoundingBox> representing the entire Earth in the EPSG:4326 Layer CRS
would be written as
<BoundingBox CRS="EPSG:4326" minx="-90" miny="-180" maxx="90" maxy="180">.
A BBOX parameter requesting


However, I'm wondering what happens if you set the following:
            Hints.putSystemDefault(Hints.FORCE_AXIS_ORDER_HONORING, "http");
            Hints.putSystemDefault(Hints.FORCE_LONGITUDE_FIRST_AXIS_ORDER,
Boolean.TRUE);

and then parse http://www.opengis.net/def/crs/EPSG/0/4326. The result
should be in lat/lon order just
like the urn factory would behave

Cheers
Andrea


-- 
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:   +39 0584 962313
mob:   +39  339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to