Hi Marc,
Your changes sounds reasonable but I think we would probably want some the
devs to try them out locally and then try them out on the build server to
ensure no issues.
Any chance you can open pull requests on github for your proposed changes?
Thanks.
-Justin
On Sat, Aug 18, 2012 at 4:21 AM, Marc Le Bihan <[email protected]> wrote:
> Hello,
>
> In order to build the master geotools version, I had to avoid this message:
> build\maven\javadoc\src\main\java\org\geotools\maven\taglet\Tutorial.java:[20,22]
> error: package com.sun.javadoc does not exist
>
> This message comes because the JDK 7.0 tools.jar cannot be invoked.
>
> <profile>
> <id>default-tools.jar</id>
> <activation>
> <property>
> <name>java.vendor</name>
> <value>Sun Microsystems Inc.</value>
> </property>
> </activation>
> <dependencies>
> <dependency>
> <groupId>com.sun</groupId>
> <artifactId>tools</artifactId>
> <version>1.5</version>
> <scope>system</scope>
> <systemPath>${java.home}/../lib/tools.jar</systemPath>
> <!-- Note: a ${tools.jar} variable exists - we should try to use it. -->
> </dependency>
> </dependencies>
> </profile>
>
> JDK 7.0 can’t stand the vendor value “Sun Microsystems Inc.” and want to
> see “Oracle Corporation” here instead.
>
> What about a change like this one in the pom.xml to allow any compiler to
> work?
>
> <!—Default activation: if Sun JDK detected. –>
> <profile>
> <id>default-tools.jar</id>
> <activation>
> <property>
> <name>java.vendor</name>
> <value>Sun Microsystems Inc.</value>
> </property>
> </activation>
> <dependencies>
> <dependency>
> <groupId>com.sun</groupId>
> <artifactId>tools</artifactId>
> <version>1.5</version>
> <scope>system</scope>
> <systemPath>${java.home}/../lib/tools.jar</systemPath>
> <!-- Note: a ${tools.jar} variable exists - we should try to use it. -->
> </dependency>
> </dependencies>
> </profile>
>
> <!—Other alternative: Activation if Oracle Corporation JDK detected. –>
> <profile>
> <id>default-tools-oracle.jar</id>
> <activation>
> <property>
> <name>java.vendor</name>
> <value>Oracle Corporation</value>
> </property>
> </activation>
> <dependencies>
> <dependency>
> <groupId>com.sun</groupId>
> <artifactId>tools</artifactId>
> <version>1.5</version>
> <scope>system</scope>
> <systemPath>${java.home}/../lib/tools.jar</systemPath>
> <!-- Note: a ${tools.jar} variable exists - we should try to use it. -->
> </dependency>
> </dependencies>
> </profile>
>
> Regards,
>
> Marc.
>
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> GeoTools-Devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel