On Fri, Aug 31, 2012 at 12:04 PM, Andrea Aime
<[email protected]>wrote:
> It helps because it makes the patch reviewable. If you have a mix of
> format and actual changes one has to painfully
> look line by line to find the actual changes in the storm caused by the
> reformat
>
> Have a look at one of Adam's diffs that I cited as being reformatted and
> go tell me what was changed, if anything.
>
Btw, there are two levels to this.
One is the maintainer committing on the module he maintains, there is no
need for review so mixed reformats
might be acceptable, although someone in the future looking at the git
history trying to determine when and how
a certain piece of code was modified will definitely curse you (since
reformats make finding out the origin
of a specific line of code much harder)
The other is patches coming from the outside, those imho should never have
reformats, and should be setup
so that a code review is facilitate for the module maintainer that has to
look into it.
This is especially important for proposals, where theoretically more than
one PSC member should be looking in the patches
and express an opinion.
Cheers
Andrea
--
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 962313
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
