Hi Andrea, comments inline.

On Sat, Sep 1, 2012 at 8:38 AM, Andrea Aime <[email protected]>wrote:

> Hi,
> I've been trying to make the release but found some problems.
> Some I could solve, some I could not, maybe some I've created in the
> attempt.
>
> First issues I've found in the build_release.sh script, the mvn clean
> would not run
> on the release tag because it missed the jar collector plugin, which was
> still
> not built. Replaced mvn clean followed by mvn install with
> mvn clean install
> Also noticed the build was running with -P process, whilst the old
> releases were
> running with -Dall instead, swithed that to -Dall since I remembered Jody
> not being able to do a uDig release due to missing artifacts.
> Committed on trunk, run the build again, this time was fine, but then
> noticed
> the -project artifact was too big, checked, it had the .git directory in
> it, so
> modified the script once again to sanitize the -project file as well and
> got
> was seemed to be a good build.
>
> Cool. Those fixes make sense.


> The I've tried the deploy script, to my surprise it actually has deployed
> the artifacts
> on both osgeo and opengeo repositories... how, I don't know.
> But then it failed on the rsych command uploading to sf because it could
> not
> create the "GeoTools 8.1 releases/8.1" folder.
> Searching around found out rsynch creates only one remote directory, not
> all.
> Also realized we would have ended up creating:
> GeoTools 8.1 releases/8.1
> GeoTools 8.2 releases/8.2
> ...
>
> instead of having a:
> GeoTools 8 Releases/8.1
> GeoTools 8 Releases/8.2
>
> and so on, so changed the way the command was run to first create the
> "GeoTools 8 Releases"
> if missing, and then do the rsych... run again, but my changes did not
> take.
> Looking on hudson found out the release-publish command was not linked to
> git,
> so I looked into the build one and copied over the necessary configurations
> (and this might have been a mistake).
>

The change to the artifact directory groupings make sense.

As for the release-publish job configuration this was intentional. If you
open up the advanced option you will see it uses the same workspace as the
release-build job. But you are right this won't update the master branch if
you only run release-publish. THere should be no problem in having that
happen though.

>
> However now running the command, even with the git user and mail, does not
> work,
> it fails at the beginning with:
>
> --------------------------------------------------
>
> Started by user hudson
> Checkout:release /
> /var/lib/hudson/jobs/geotools-release/workspace/build/release -
> hudson.remoting.LocalChannel@7e7ad43
> Using strategy: Default
> Checkout:release /
> /var/lib/hudson/jobs/geotools-release/workspace/build/release -
> hudson.remoting.LocalChannel@7e7ad43
> Fetching changes from the remote Git repository
> Fetching upstream changes from git@github-geotools:geotools/geotools.git
> Commencing build of Revision 383cc7dc16c043db7965ba0162b8ec98fb620993
> (origin/master)
> Checking out Revision 383cc7dc16c043db7965ba0162b8ec98fb620993
> (origin/master)
> FATAL: Could not apply tag hudson-geotools-release-publish-11
> hudson.plugins.git.GitException: Could not apply tag
> hudson-geotools-release-publish-11
> at hudson.plugins.git.GitAPI.tag(GitAPI.java:680)
>  at hudson.plugins.git.GitSCM.createInternalTag(GitSCM.java:1615)
> at hudson.plugins.git.GitSCM.access$400(GitSCM.java:105)
>  at hudson.plugins.git.GitSCM$1.invoke(GitSCM.java:736)
> at hudson.plugins.git.GitSCM$1.invoke(GitSCM.java:687)
>  at hudson.FilePath.act(FilePath.java:758)
> at hudson.FilePath.act(FilePath.java:740)
>  at hudson.plugins.git.GitSCM.getBuildConfig(GitSCM.java:687)
> at hudson.plugins.git.GitSCM.checkout(GitSCM.java:647)
>  at hudson.model.AbstractProject.checkout(AbstractProject.java:1479)
> at
> hudson.model.AbstractBuild$AbstractRunner.checkout(AbstractBuild.java:507)
>  at hudson.model.AbstractBuild$AbstractRunner.run(AbstractBuild.java:424)
> at hudson.model.Run.run(Run.java:1366)
>  at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46)
> at hudson.model.ResourceController.execute(ResourceController.java:88)
>  at hudson.model.Executor.run(Executor.java:145)
> Caused by: hudson.plugins.git.GitException: Error performing command: git
> tag -a -f -m Hudson Build #11 hudson-geotools-release-publish-11
> Command "git tag -a -f -m Hudson Build #11
> hudson-geotools-release-publish-11" returned status code 128:
> *** Please tell me who you are.
>
> Run
>
>   git config --global user.email "[email protected]"
>   git config --global user.name "Your Name"
>
> to set your account's default identity.
> Omit --global to set the identity only in this repository.
>
> fatal: empty ident name (for <obiwan.openplans.org>) not allowed
>
> at hudson.plugins.git.GitAPI.launchCommandIn(GitAPI.java:730)
>  at hudson.plugins.git.GitAPI.launchCommand(GitAPI.java:692)
> at hudson.plugins.git.GitAPI.launchCommand(GitAPI.java:703)
>  at hudson.plugins.git.GitAPI.tag(GitAPI.java:678)
> ... 15 more
> Caused by: hudson.plugins.git.GitException: Command "git tag -a -f -m
> Hudson Build #11 hudson-geotools-release-publish-11" returned status code
> 128:
> *** Please tell me who you are.
>
> Run
>
>   git config --global user.email "[email protected]"
>   git config --global user.name "Your Name"
>
> to set your account's default identity.
> Omit --global to set the identity only in this repository.
>
> fatal: empty ident name (for <obiwan.openplans.org>) not allowed
>
> at hudson.plugins.git.GitAPI.launchCommandIn(GitAPI.java:723)
> ... 18 more
>
> --------------------------------------------------
>
> And here I'm confused, the init_git command is run with the username and
> password just like
> in the build one, but here it does not seem to work?
> I guess it is because the publish script is actually pushing over the tag
> to github, but it
> does not have the proper password?
> Yet, that does not quite match what I'm seeing in the error messages.
>

Yeah. this happens when hudson tires to tag every build in the local git
repo. I usually turn this off because i don't have the local identity for
the user that runs hudson. The option is called "skip internal tag". I just
updated the git config  you added to release-publish to skip internal tag
so this should go away.

>
> Ideas?
>
> Cheers
> Andrea
>
> --
> ==
> Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
> information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054  Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax:   +39 0584 962313
> mob:   +39  339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> GeoTools-Devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>


-- 
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to