On Mon, Sep 24, 2012 at 7:28 AM, Sebastian Graca <sgr...@ispik.pl> wrote:
> Hello!
>
> I have created a patch for GeoTools which implements whole layer
> transparency (for layers and labels) and allows to skip label rendering
> for a layer. The patch is submitted as a github pull request
> https://github.com/geotools/geotools/pull/32
>
> Andrea asked me to explain what I try to do, so I will try to describe
> what is being done and why.
>
I agree with Jody what you're looking for it not transparency control
(which is correctly
implemented in SLD), but composition control.
The latter sounds like something which might make sense as a vendor
parameter in
FeatureTypeStyle for example, allowing the user to specify one of the
various
composition modes Java2D allows for:
http://docs.oracle.com/javase/tutorial/2d/advanced/compositing.html
and then allow also a extra param for opacity.
In the end what you're doing in your patch does not look significantly
different
from the existing fts merging command, you are just changing the opacity
from
1 to a different value no?
Hiding labels looks something that one could achieve also by parametrizing
the SLD
and having the Label element either pick an attribute or an empty value, or
using
your own label cache.
Adding API to hide labels seems pretty narrow use case... if we have an
interest to
go there wondering if it would be better to allow a layer to have some sort
of
style transformer that changes the style contents before rendering, in
order to
make this kind of transformation just one of the possible ones (for
example, for
web mapping one might be also interested to do the opposite, turn off
everything
but the labels to do only the vectors in tiled mode, and only the labels in
full map
mode).
This would allow to perform the change in a well centralized place without
having to
mess with the rendering code and pass everywhere the hidelabels flag like
the patch does.
I'm sorry for the negative feedback, especially since the code is otherwise
clean and
tested, but before making feature changes to the code base you should
really double check
with the GeoTools community on the direction to take.
Cheers
Andrea
--
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://ad.doubleclick.net/clk;258768047;13503038;j?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
