On Thu, Oct 11, 2012 at 11:59 PM, Andrea Aime
<[email protected]>wrote:
> On Fri, Oct 12, 2012 at 3:22 AM, Jody Garnett <[email protected]>wrote:
>
>> Jody, I see you are making pull requests which involve changes to the
>> referencing module
>> and merge them before getting any feedback from the maintainer (ah hem,
>> me).
>>
>> Would it be possible to work on a branch so that you can reach your
>> deliverable, and
>> allow some time for the reviews of the modules you're not maintainer of?
>>
>> I have a branch going on, but am doing this changes hand in glove with
>> uDig master. On the "bright" side I have chased
>> the remaining issues over into the deegree project, and thus have bought
>> "more time" before this pull request is needed
>> contract wise.
>>
>> I was however hoping to issue a uDig 1.3.3-SNAPSHOT allowing ows9
>> participants to test the correct functionality.
>>
>> Err... you could have a branch both sides
>
>> I'll have a look at the changes you made this weekend (and may have to
>> modify
>> changes, hopefully not to revert any...)
>>
>> Fair enough, mostly trying to get the toString methods to report back
>> what is going on.
>>
>> I am away next week and will not be in the geotools meeting; feel free to
>> roast me for accepting my own pull requests.
>>
>>
> It's not about accepting your own pull request, what worries me most is
> changes in the referencing module
> which seem to be directed mostly by the haste of the moment than by a good
> understanding of what
> needs fixing and how.
> Commits are also not directly related to the jiras being opened, for
> example it's hard to tell what
> happened with https://jira.codehaus.org/browse/GEOT-4286, has it been
> reverted?
> One final worry bit is that the changes to referencing do not seem to be
> covered by their own tests
>
> +1. Seems like a faux paux to me to apply these pull requests without
review from the module maintainer. Especially a module as core as
referencing.
Cheers
> Andrea
>
> --
> ==
> Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
> information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
>
>
> ------------------------------------------------------------------------------
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> _______________________________________________
> GeoTools-Devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
