![]() |
|
|
|
|
Issue Type:
|
![Improvement]() Improvement
|
|
Affects Versions:
|
9.0-M0 |
|
Assignee:
|
Rini Angreani
|
|
Components:
|
app-schema plugin |
|
Created:
|
03/Nov/12 6:43 AM
|
|
Description:
|
During GEOT-4181 feature collection clean up I had a chance to review / fix / harm several app-schema classes. And in many cases I was able to introduce the correct Generics mark support classes as only working with SimpleFeature.
This causes a few regressions in app-schema code, for example in FilteringMappingFeatureIterator where there are un-safe casts to SimpleFeature.
I do not know exactly how this code is called, it could be that SimpleFeature is indeed expected (and the only option) at this stage in the code, however this assumption is not backed by the compiler leaving room for failure.
Short term:
- Please review FilteringMappingFeatureIterator
- Please review each call to FeatureCollection.features() to double check I did not miss any try/finally blocks
Long term we need to set up support classes for app-schema. Support classes travel in pairs (SimpleFeatureCollection / SimpleFeatureIterator) to accomplish a specific goal. We need to review the support classes for SimpleFeature work, and ensure generic Feature support classes are available that mirror this functionality.
|
|
Project:
|
GeoTools
|
|
Priority:
|
![Major]() Major
|
|
Reporter:
|
Jody Garnett
|
|
|
|
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
------------------------------------------------------------------------------
LogMeIn Central: Instant, anywhere, Remote PC access and management.
Stay in control, update software, and manage PCs from one command center
Diagnose problems and improve visibility into emerging IT issues
Automate, monitor and manage. Do more in less time with Central
http://p.sf.net/sfu/logmein12331_d2d
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
