I commented on github, will do so again here:
1. The changes were smoothly applied, did not see any major workarounds like in
GeoTools or uDig
2 We could make use of some of those DataUtilities methods.
3. I tend to do try / finally around each FeatureIterator
4. The security feature collections were fine, I wanted to make sure there was
no way to accidentally get to the delegate and "add" anything. And yes they are
all wrapped up
--
Jody Garnett
On Monday, 12 November 2012 at 10:46 AM, Justin Deoliveira wrote:
>
>
> On Sat, Nov 10, 2012 at 2:09 AM, Andrea Aime <[email protected]
> (mailto:[email protected])> wrote:
> > Hi,
> > I was chatting with Jody on IRC and it seems the feature collection work on
> > the Geotools side is done with a pull request ready to be merged.
> > uDig seems to be ready as well, whilst GeoServer wise as far as I understand
> > we have a branch that Justin made that also works, but no pull request.
> >
>
> I pushed the changes up to my own repo last weekend and was waiting for a
> review, specially of the secure feature collection part of the changes.
> Perhaps I missed it but never heard back if it looked ok or not.
> >
> > If everything is ready can we also have the pull request on the Geoserver
> > side
> > so that we can give it a kick and call this refactor done?
> >
>
>
> https://github.com/geoserver/geoserver/pull/61
>
> >
> > Cheers
> > Andrea
> >
> > --
> > ==
> > Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
> > information.
> > ==
> >
> > Ing. Andrea Aime
> > @geowolf
> > Technical Lead
> >
> > GeoSolutions S.A.S.
> > Via Poggio alle Viti 1187
> > 55054 Massarosa (LU)
> > Italy
> > phone: +39 0584 962313 (tel:%2B39%200584%20962313)
> > fax: +39 0584 1660272 (tel:%2B39%200584%201660272)
> > mob: +39 339 8844549 (tel:%2B39%20%C2%A0339%208844549)
> >
> > http://www.geo-solutions.it
> > http://twitter.com/geosolutions_it
> >
> > -------------------------------------------------------
> >
> > ------------------------------------------------------------------------------
> > Everyone hates slow websites. So do we.
> > Make your web apps faster with AppDynamics
> > Download AppDynamics Lite for free today:
> > http://p.sf.net/sfu/appdyn_d2d_nov
> > _______________________________________________
> > GeoTools-Devel mailing list
> > [email protected]
> > (mailto:[email protected])
> > https://lists.sourceforge.net/lists/listinfo/geotools-devel
> >
>
>
>
> --
> Justin Deoliveira
> OpenGeo - http://opengeo.org
> Enterprise support for open source geospatial.
>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_nov
>
> _______________________________________________
> GeoTools-Devel mailing list
> [email protected]
> (mailto:[email protected])
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
