Thanks Andrea.
On Wed, Nov 21, 2012 at 10:45 AM, Andrea Aime
<andrea.a...@geo-solutions.it>wrote:
> On Sat, Nov 17, 2012 at 1:10 AM, Justin Deoliveira
> <jdeol...@opengeo.org>wrote:
>
>> OK... i went around on this one a couple of times... decided in the end
>> to just do the bare minimum to get JDBCDataStoreFactory to delegate to
>> DataSourceFactorySpi. Here is a first cut.
>>
>>
>> https://github.com/jdeolive/geotools/commit/ac06cb8edf8715ac33cc97d50da8f0ae81f38637
>>
>> I still need to test it on a few more databases but h2 and postgis show
>> no problems.
>>
>
> I believe it's looking good but I'm not so sure about one point, that is,
> the fact that the only
> way I see to provide the data source SPI is to do programmatic injection
> of it
> in the jdbc factory by calling a setter.
>
> Given that people are supposed to use DataStoreFinder.getDataStore(Map)
> when creating stores,
> wouldn't it be better to pass the data source factory (or its name, with a
> converter looking up
> the possible implementations by name) as a data store parameter?
>
Makes sense. I think adding an additional store factory parameter named
"dstype" or something and looking up the source factory implementation
based on that would work? One of the changes I mad to the source factory
api was basically to add the équivaillent of "dbtype" which serves as
unique identifier for data source factories.
>
> Cheers
> Andrea
>
>
>
> --
> ==
> Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
> information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
>
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
