Hi. >> For most data stores we expect them to handle this natively based in an >> index - what datastore were you testing with ?
I'm using IndexedShapefileDataStore, but the file does not have an index, which I guess may be pretty common. > > This kind of patch was already tried, but it broke geogit-versioned. > Have a look here for a discussion... maybe someone has time to figure out a > way to solve the issue? > > http://jira.codehaus.org/browse/GEOT-3986 The patch you submitted there is the perfect implementation of what I was actually proposing. It's a pity that it breaks the build because it really makes the difference in terms of speed. Unfortunately, I haven't been able to compile geogit-versioned on master and reproduce the broken build to take a look. So, comparing the ID of the Identifiers[1] works, but checking their equality through contains()[2] does not. This happens because there is an implementation of Identifier that checks more things than the getID() in the equals(), right? Isn't it inconsistent with Identifier javadocs[3]? ResourceIdImpl is the only one that I've found that checks "more things" than the getID() in the equals. Eventually, the filter may return true for ResourceIds that are not equals() but that share the ID. Regards. [1] for(Object identifier : fids) { Identifier fid = (Identifier) identifier; if(fid.getID().equals(evaluate)) { [2] fids.contains(ff.featureId(evaluate)) [3] Identifier is a data object, equals is based just on getID() > > Cheers > Andrea > > > -- > == > Our support, Your Success! Visit http://opensdi.geo-solutions.it for more > information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions S.A.S. > Via Poggio alle Viti 1187 > 55054 Massarosa (LU) > Italy > phone: +39 0584 962313 > fax: +39 0584 1660272 > mob: +39 339 8844549 > > http://www.geo-solutions.it > http://twitter.com/geosolutions_it > > ------------------------------------------------------- > > > ------------------------------------------------------------------------------ > LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial > Remotely access PCs and mobile devices and provide instant support > Improve your efficiency, and focus on delivering more value-add services > Discover what IT Professionals Know. Rescue delivers > http://p.sf.net/sfu/logmein_12329d2d > _______________________________________________ > GeoTools-Devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geotools-devel > ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
