okay, thanks for the prompt reply. Created a pull request <https://github.com/geotools/geotools/pull/115> Lets see if Jody has any objection?
On Fri, Jan 25, 2013 at 2:29 PM, Justin Deoliveira <jdeol...@opengeo.org> wrote: > No objection here. I don't remember a strong reason to make that method > final and agree looks to be more consistent as non-final as the other write > methods are. > > > On Fri, Jan 25, 2013 at 10:08 AM, Gabriel Roldan <grol...@opengeo.org> > wrote: >> >> Hi all, specially Jody and Justin as ContentDataStore creators. >> I'd need to remove the final modifier from >> ContentFeatureStore.addFeatures in order for the geogit datastore to >> be based on the ContentDataStore family of classes and use a better >> performant way adding features instead of relying on the provided >> FeatureWriter. >> I think this would follow suite with the >> ContentFeatureStore.modifyFeatures and removeFeatures, which also >> provide a default behavior but are not marked final. >> >> This is the only problem I found so far in creating this new DataStore >> based on the ContentDataStore framework, so kudos for it. >> Please let me know if there's any problem in applying that change on >> master: >> >> >> <https://github.com/groldan/geotools/commit/a714e9458abca0c1bea45e3de6f50867517835db> >> >> Cheers, >> Gabriel >> -- >> Gabriel Roldan >> OpenGeo - http://opengeo.org >> Expert service straight from the developers. > > > > > -- > Justin Deoliveira > OpenGeo - http://opengeo.org > Enterprise support for open source geospatial. -- Gabriel Roldan OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnnow-d2d _______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
