Brett,
The test failure is certainly related to my work and it is not immediately
obvious to me why it is failing for you. I'm going to refresh locally and
see if I see the same problem. I am wondering if this could be some sort
of CR/LF DOS vs. Unix text thing though that seems unlikely.
Best regards,
Frank
On Fri, May 31, 2013 at 4:52 AM, Brett Walker
<[email protected]>wrote:
> Frank,
>
> This failure seems to stem from the patch you supplied to fix GEOT-4260.
>
> I'm just wondering if the patch was fully tested. Would the error be in
> the test code or the source code?
>
> The test code has been a recent addition to the code base. The source code
> is long standing.
>
> The small alteration you made to TableWriter had no affect on the test
> outcome if included or excluded.
>
> Any ideas?
>
> Brett
>
> ------------------------------
> *From:* Brett Walker [[email protected]]
> *Sent:* Friday, 31 May 2013 8:08 PM
> *To:* [email protected]
> *Subject:* [Geotools-devel] Build broken on master trunk
>
> Hi Devs,
>
> I have come across a build issue with the master branch.
>
> I cloned the git repository from https://github.com/geotools/geotools/using
> TortiseGit
>
> D:\Geotools\Git\geotools\geotools\mvn -version
> Apache Maven 3.0.4 (r1232337; 2012-01-17 19:44:56+1100)
> Maven home: D:\Apache\Maven\3.0
> Java version: 1.7.0_17, vendor: Oracle Corporation
> Java home: D:\Java\jdk1.7\jre
> Default locale: en_AU, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>
> D:\Geotools\Git\geotools\geotools\mvn clean install
>
> resulted in the build failing in the Metadata module with two failures.
> From the surefire test report
>
>
> -------------------------------------------------------------------------------
> Test set: org.geotools.io.TableWriterTest
>
> -------------------------------------------------------------------------------
> Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.015 sec
> <<< FAILURE!
> testExample(org.geotools.io.TableWriterTest) Time elapsed: 0 sec <<<
> FAILURE!
> org.junit.ComparisonFailure: expected:<Prénom Nom [
> -------------------
> Idéphonse Laporte
> Sarah Coursi
> Yvan Dubois ]
> > but was:<Prénom Nom [
> -------------------
> Idéphonse Laporte
> Sarah Coursi
> Yvan Dubois
> ]
> >
> at org.junit.Assert.assertEquals(Assert.java:99)
> at org.junit.Assert.assertEquals(Assert.java:117)
> at org.geotools.io.TableWriterTest.testExample(TableWriterTest.java:55)
> ... rest of stacktrace deleted
>
> testToStringWithoutFlush(org.geotools.io.TableWriterTest) Time elapsed: 0
> sec <<< FAILURE!
> org.junit.ComparisonFailure: expected:<Source Point: 1.234[
> Target Point: 2.345]
> > but was:<Source Point: 1.234[
> Target Point: 2.345
> ]
> >
> at org.junit.Assert.assertEquals(Assert.java:99)
> at org.junit.Assert.assertEquals(Assert.java:117)
> at
> org.geotools.io.TableWriterTest.testToStringWithoutFlush(TableWriterTest.java:77)
> ... rest of stacktrace deleted.
>
> It seems that an extra new line is inserted when the table is 'ended'
>
> Perhaps not a big problem but it breaks the build.
>
> Brett
>
>
>
>
> ------------------------------------------------------------------------------
> Get 100% visibility into Java/.NET code with AppDynamics Lite
> It's a free troubleshooting tool designed for production
> Get down to code-level detail for bottlenecks, with <2% overhead.
> Download for free and get started troubleshooting in minutes.
> http://p.sf.net/sfu/appdyn_d2d_ap2
> _______________________________________________
> GeoTools-Devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
--
---------------------------------------+--------------------------------------
I set the clouds in motion - turn up | Frank Warmerdam,
[email protected]
light and sound - activate the windows | http://pobox.com/~warmerdam
and watch the world go round - Rush | Geospatial Software Developer
------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite
It's a free troubleshooting tool designed for production
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap2
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
