> All of the above is achieved by associating the new set of attributes each 
> with a OGC Expression, like in the test cases, see the three methods setting 
> up some transformations:
> 
> https://github.com/geotools/geotools/blob/master/modules/unsupported/transform/src/test/java/org/geotools/data/transform/AbstractTransformTest.java
> 
> The module takes care of all needed filter and name transformations, and if 
> the transformations are invertible (that is, pretty much just attribute 
> rename at the moment) then it also preserves the writability of the original 
> SimpleFeatureStore. 
> 
> The test coverage is good (69%), IP wise there are no issues, wrote all the 
> code myself (though I guess I need to add a review.txt in there, right?)
Thought I did some of the ground work for uDig, and back ported it as a process 
for GeoTools. Still excellent functionality to have :-) 
> There are no docs, but I plan to add a page of docs turning the unit tests 
> into examples along with the pull request that will graduate the module.
> 
> 

Thanks Andrea, I know docs are a pain but I am fond of them. So easy for much 
of the library to lurk unseen like an iceberg.
> Ah, the final location is a bit of a mystery... this thing is not a plugin in 
> the strict sense, there is no factory and no store, you are supposed to call 
> TransformFactory.transform(source, targetName, listOfAttributeDefinitions) in 
> order to get the transformed source/store.
> 
> 

You could consider it for extension then? (i.e. additional functionality built 
onto of the core library).
> As such is more similar to a ReprojectingFeatureCollection than a stand alone 
> data store... so... where should it go? Library?
> However, setting up a factory and store is not un-thinkable, but it would be 
> a bit odd to have a store whose one of the source params is another store... 
> 
> 

Actually that is valid, if you look at pre generalised feature support, the 
connection parameters are used to "lookup" other stores in the hosting 
application's catalog.

Jody
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to