Andrea,
It was my misunderstanding on my part. It was trying to have a discussion which
would educate subsequent commits. This being the first of several. I should
have had the discussion on this mailing list rather on the pull request.
The pull request (PR#208) is finished. Could you provide feedback or commit it
please.
Brett
From: andrea.a...@gmail.com [mailto:andrea.a...@gmail.com] On Behalf Of Andrea
Aime
Sent: Wednesday, 26 June 2013 4:10 PM
To: Brett Walker
Cc: Geotools-Devel list
Subject: Re: [Geotools-devel] Pull Request Policy
On Tue, Jun 25, 2013 at 11:39 PM, Brett Walker
<brett.wal...@geometryit.com<mailto:brett.wal...@geometryit.com>> wrote:
Ignoring worthwhile patches could appear to give the cold shoulder to the wider
community.
Ah, if you were referring to this pull request:
https://github.com/geotools/geotools/pull/208
the reason why it's not applied yet is that the pull turned into a discussion
and it's not clear
if you're done with it or not.
As a rule of thumb, keep every pull request short and to the point, and unless
there is something
wrong about the request, avoid growing its scope, make other pull requests
instead.
Generally speaking, the easier it is to just give you a straight yes/no answer
on a pull request,
the quicker it's merged. If your pull request ends up in my "weekend review"
thing, you get feedback
once a week, which makes for very looong discussions
Cheers
Andrea
--
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
