No it is fine I cherry-picked the original commit.
--
Jody Garnett
On 18/07/2013, at 5:53 PM, Robin Pradel <r...@ivu.de> wrote:
> Is there any todo for me, or is it possible to reuse the previous pull
> requests?
>
> Regards,
> Robin
>
> Von: Jody Garnett [mailto:jody.garn...@gmail.com]
> Gesendet: Donnerstag, 18. Juli 2013 01:48
> An: Robin Pradel; Ben Caradoc-Davies
> Cc: geotools-devel@lists.sourceforge.net
> Betreff: Re: [Geotools-devel] Preparing for the release
>
> Robin and Ben:
>
> If you can clean up this patch today, and Ben verifies I can regenerate the
> release. It looks like we may get a last minuet fix for Java 7 (based on the
> other email thread).
>
> --
> Jody Garnett
>
> On Wednesday, 17 July 2013 at 9:40 PM, Jody Garnett wrote:
>
> It is only necessary as Kevin is waiting on me before releasing GWC.
> I am not sure about the permissions of the test database, most of our tests
> create the tables and so on as needed. Perhaps Ben will be able to give you
> more information.
> --
> Jody Garnett
>
> On Wednesday, 17 July 2013 at 8:55 PM, Robin Pradel wrote:
>
> Ok, but I think this is not really necessary.
>
> Only somebody has to grant the permission for synonyms to database access of
> the test run, or am I wrong?
>
> Regards,
> Robin
>
> Von: Jody Garnett [mailto:jody.garn...@gmail.com]
> Gesendet: Mittwoch, 17. Juli 2013 12:46
> An: Ben Caradoc-Davies
> Cc: Robin Pradel; geotools-devel@lists.sourceforge.net
> Betreff: Re: [Geotools-devel] Preparing for the release
>
> Well that is sadly terrible :(
>
> I will rollback the change and start my release story again.
>
> --
> Jody Garnett
>
> On Wednesday, 17 July 2013 at 7:19 PM, Ben Caradoc-Davies wrote:
>
> Jody,
>
> it took twice as long a normal to run and failed with a NPE locally:
> OracleTypeNamesTest>OnlineTestCase.run:123->JDBCTypeNamesTest.testTypeNames:36
> ยป NullPointer
>
> And on Jenkins:
>
> https://cgsrv8.arrc.csiro.au/jenkins/view/geoserver-master/job/geotools-master/529/consoleText
>
> Kind regards,
> Ben.
>
> On 17/07/13 17:02, Ben Caradoc-Davies wrote:
> I am running the jdbc-oracle online tests on master against Oracle 11g
> 11.2.0.3.0.
>
> Don't you think it is a little close to release to squeeze this one in?
>
> Kind regards,
> Ben.
>
> On 17/07/13 16:09, Jody Garnett wrote:
> I had a look, but have a hesitation accepting a pull request when I am
> not in position to test (against oracle for SYNONYM).
>
> I have just finished my pre-flight checks for GeoTools, but would like
> to see if we can get this in since you have asked so nicely. While we
> wait to see if an active JDBC developer is in position to review I will
> start a build locally to confirm your change "works for me".
> --
> Jody Garnett
>
> On Wednesday, 17 July 2013 at 5:23 PM, Robin Pradel wrote:
>
> Hi developers with permission to accept/apply pull requests,
>
> Can somebody have a look at the pull requests mentioned below? These
> ones solve the issue about synonyms in databases
> http://jira.codehaus.org/browse/GEOT-4486
>
> Andrea had a look at the code in a previous pull request which was ok
> with a small test case fix (but on closed branch).
>
> Yours sincerely.
>
> Robin Pradel
>
> System Ingenieur
>
> IVU Traffic Technologies AG
>
> Bundesallee 88, D-12161 Berlin
>
> http://www.ivu.de <http://www.ivu.de/>
>
> *Von:*andrea.a...@gmail.com [mailto:andrea.a...@gmail.com] *Im Auftrag
> von *Andrea Aime
> *Gesendet:* Montag, 15. Juli 2013 14:50
> *An:* Robin Pradel
> *Cc:* geotools-devel@lists.sourceforge.net
> <mailto:geotools-devel@lists.sourceforge.net>
> *Betreff:* Re: [Geotools-devel] Preparing for the release
>
> On Mon, Jul 15, 2013 at 2:44 PM, Robin Pradel <r...@ivu.de
> <mailto:r...@ivu.de>> wrote:
>
> Hi Andrea,
>
> I fixed the pull requests for synonyms in the JDBCDataStore:
>
> Master: https://github.com/geotools/geotools/pull/227
>
> 9.x: https://github.com/geotools/geotools/pull/226
>
> Can you apply these ones for the coming release? That would be
> very nice.
>
> Hi Robin,
>
> unfortunately I won't have time to look again at them until next
> weekend, the working
>
> week is full beyond salvation (just got back from vacations, lots of
> stuff piled up).
>
> However, there are other developers on this mailing list, maybe
> someone else
>
> wants to have a look?
>
> Cheers
>
> Andrea
>
> --
>
> ==
>
> Our support, Your Success! Visit http://opensdi.geo-solutions.it for
> more information.
>
> ==
>
> Ing. Andrea Aime
>
> @geowolf
>
> Technical Lead
>
> GeoSolutions S.A.S.
>
> Via Poggio alle Viti 1187
>
> 55054 Massarosa (LU)
>
> Italy
>
> phone: +39 0584 962313
>
> fax: +39 0584 1660272
>
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
>
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
> ------------------------------------------------------------------------------
>
> See everything from the browser to the database with AppDynamics
> Get end-to-end visibility with application monitoring from AppDynamics
> Isolate bottlenecks and diagnose root cause in seconds.
> Start your free trial of AppDynamics Pro today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
>
> _______________________________________________
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net
> <mailto:GeoTools-Devel@lists.sourceforge.net>
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
>
> ------------------------------------------------------------------------------
>
> See everything from the browser to the database with AppDynamics
> Get end-to-end visibility with application monitoring from AppDynamics
> Isolate bottlenecks and diagnose root cause in seconds.
> Start your free trial of AppDynamics Pro today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
>
>
>
>
> _______________________________________________
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
> --
> Ben Caradoc-Davies <ben.caradoc-dav...@csiro.au>
> Software Engineer
> CSIRO Earth Science and Resource Engineering
> Australian Resources Research Centre
>
>
>
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
