I like the idea of dropping any dependencies that we don't need. +1 on that
but no strong opinion if it's a hassle to port over.
On Sun, Aug 25, 2013 at 3:17 PM, Jody Garnett <[email protected]>wrote:
> It can be dropped, it is just easier, ie more java like, than the w3c DOM
> API.
>
> I think the original author has moved on to another XML API now.
>
> --
> Jody Garnett
>
> On 26/08/2013, at 2:33 AM, Andrea Aime <[email protected]>
> wrote:
>
> Hi,
> about the JDOM upgrade, had a quick look and I'm starting to wonder if
> it's a bit like
> Xerces, that is, something that could be replaced with the functionality
> offered by the
> JDK itself.
>
> For example, GeoServer tests use org.w3c.Document extensively, without the
> need
> of JDOM
>
> I had a quick look, and indeed there are not that many classes using JDOM:
>
> ./modules/extension/app-schema/app-schema/src/main/java/org/geotools/data/complex/xml/XmlResponse.java:import
> org.jdom.Document;
> ./modules/extension/app-schema/app-schema/src/main/java/org/geotools/data/complex/xml/XmlXpathFilterData.java:import
> org.jdom.Document;
> ./modules/extension/app-schema/app-schema/src/main/java/org/geotools/util/XmlXpathUtilites.java:
> } else if (value instanceof org.jdom.Element) {
> ./modules/extension/app-schema/app-schema/src/main/java/org/geotools/util/XmlXpathUtilites.java:
> if (value instanceof org.jdom.Attribute) {
> ./modules/extension/app-schema/app-schema/src/main/java/org/geotools/util/XmlXpathUtilites.java:import
> org.jdom.Document;
> ./modules/extension/app-schema/app-schema/src/main/java/org/geotools/util/XmlXpathUtilites.java:
> * Ulities class for xpath handling on a jdom document object
> ./modules/extension/app-schema/app-schema/src/main/java/org/geotools/util/XmlXpathUtilites.java:
> unwrappedValue = ((org.jdom.Attribute) value).getValue();
> ./modules/extension/app-schema/app-schema/src/main/java/org/geotools/util/XmlXpathUtilites.java:
> unwrappedValue = ((org.jdom.Element) value).getValue();
> ./modules/library/coverage/src/main/java/org/geotools/coverage/grid/io/imageio/geotiff/GeoTiffIIOMetadataEncoder.java:import
> org.jdom.Element;
> ./modules/library/main/src/main/java/org/geotools/data/ows/Response.java:import
> org.jdom.JDOMException;
> ./modules/library/main/src/main/java/org/geotools/data/ows/ServiceExceptionParser.java:import
> org.jdom.Document;
> ./modules/library/main/src/main/java/org/geotools/data/ows/ServiceExceptionParser.java:import
> org.jdom.Element;
> ./modules/library/main/src/main/java/org/geotools/data/ows/ServiceExceptionParser.java:import
> org.jdom.input.SAXBuilder;
> ./modules/library/main/src/main/java/org/geotools/data/ows/ServiceExceptionParser.java:import
> org.jdom.JDOMException;
> ./modules/plugin/geotiff/src/main/java/org/geotools/gce/geotiff/GeoTiffWriter.java:import
> org.jdom.Document;
> ./modules/plugin/geotiff/src/main/java/org/geotools/gce/geotiff/GeoTiffWriter.java:import
> org.jdom.Element;
> ./modules/plugin/geotiff/src/main/java/org/geotools/gce/geotiff/GeoTiffWriter.java:import
> org.jdom.input.DOMBuilder;
> ./modules/plugin/geotiff/src/main/java/org/geotools/gce/geotiff/GeoTiffWriter.java:import
> org.jdom.JDOMException;
> ./modules/plugin/geotiff/src/main/java/org/geotools/gce/geotiff/GeoTiffWriter.java:import
> org.jdom.output.DOMOutputter;
> ./modules/plugin/geotiff/src/main/java/org/geotools/gce/geotiff/GeoTiffWriter.java:import
> org.jdom.Parent;
> ./modules/plugin/shapefile/src/main/java/org/geotools/data/shapefile/shp/xml/ShpXmlFileReader.java:import
> org.jdom.Document;
> ./modules/plugin/shapefile/src/main/java/org/geotools/data/shapefile/shp/xml/ShpXmlFileReader.java:import
> org.jdom.Element;
> ./modules/plugin/shapefile/src/main/java/org/geotools/data/shapefile/shp/xml/ShpXmlFileReader.java:import
> org.jdom.input.SAXBuilder;
> ./modules/plugin/shapefile/src/main/java/org/geotools/data/shapefile/shp/xml/ShpXmlFileReader.java:import
> org.jdom.JDOMException;
> ./modules/unsupported/app-schema/webservice/src/main/java/org/geotools/data/ws/WS_DataStore.java:import
> org.jdom.Document;
> ./modules/unsupported/app-schema/webservice/src/main/java/org/geotools/data/ws/WS_DataStore.java:import
> org.jdom.input.SAXBuilder;
> ./modules/unsupported/app-schema/webservice/src/main/java/org/geotools/data/ws/WS_DataStore.java:import
> org.jdom.JDOMException;
> ./modules/unsupported/app-schema/webservice/src/main/java/org/geotools/data/ws/WS_DataStore.java:import
> org.jdom.output.Format;
> ./modules/unsupported/app-schema/webservice/src/main/java/org/geotools/data/ws/WS_DataStore.java:import
> org.jdom.output.XMLOutputter;
> ./modules/unsupported/app-schema/webservice/src/main/java/org/geotools/filter/AsXpathFunctionExpression.java:import
> org.jdom.Document;
> ./modules/unsupported/app-schema/webservice/src/test/java/org/geotools/data/complex/XmlDataStoreTest.java:import
> org.jdom.Document;
> ./modules/unsupported/app-schema/webservice/src/test/java/org/geotools/data/complex/XmlDataStoreTest.java:import
> org.jdom.input.SAXBuilder;
> ./modules/unsupported/app-schema/webservice/src/test/java/org/geotools/data/complex/XmlDataStoreTest.java:import
> org.jdom.JDOMException;
> ./modules/unsupported/coverage-experiment/geotiff/src/main/java/org/geotools/coverage/io/geotiff/GeoTiffWriter.java:import
> org.jdom.Document;
> ./modules/unsupported/coverage-experiment/geotiff/src/main/java/org/geotools/coverage/io/geotiff/GeoTiffWriter.java:import
> org.jdom.Element;
> ./modules/unsupported/coverage-experiment/geotiff/src/main/java/org/geotools/coverage/io/geotiff/GeoTiffWriter.java:import
> org.jdom.input.DOMBuilder;
> ./modules/unsupported/coverage-experiment/geotiff/src/main/java/org/geotools/coverage/io/geotiff/GeoTiffWriter.java:import
> org.jdom.JDOMException;
> ./modules/unsupported/coverage-experiment/geotiff/src/main/java/org/geotools/coverage/io/geotiff/GeoTiffWriter.java:import
> org.jdom.output.DOMOutputter;
> ./modules/unsupported/coverage-experiment/geotiff/src/main/java/org/geotools/coverage/io/geotiff/GeoTiffWriter.java:import
> org.jdom.Parent;
> ./modules/unsupported/geotiff_new/src/main/java/org/geotools/coverage/grid/imageio/geotiff/metadata/GeoTiffIIOMetadataEncoder.java:import
> org.jdom.Element;
> ./modules/unsupported/geotiff_new/src/main/java/org/geotools/gce/geotiff/GeoTiffUtils.java:import
> org.jdom.Document;
> ./modules/unsupported/geotiff_new/src/main/java/org/geotools/gce/geotiff/GeoTiffUtils.java:import
> org.jdom.Element;
> ./modules/unsupported/geotiff_new/src/main/java/org/geotools/gce/geotiff/GeoTiffUtils.java:import
> org.jdom.input.DOMBuilder;
> ./modules/unsupported/geotiff_new/src/main/java/org/geotools/gce/geotiff/GeoTiffUtils.java:import
> org.jdom.JDOMException;
> ./modules/unsupported/geotiff_new/src/main/java/org/geotools/gce/geotiff/GeoTiffUtils.java:import
> org.jdom.output.DOMOutputter;
> ./modules/unsupported/geotiff_new/src/main/java/org/geotools/gce/geotiff/GeoTiffUtils.java:import
> org.jdom.Parent;
> ./modules/unsupported/shapefile-old/src/main/java/org/geotools/data/shapefile/shp/xml/ShpXmlFileReader.java:import
> org.jdom.Document;
> ./modules/unsupported/shapefile-old/src/main/java/org/geotools/data/shapefile/shp/xml/ShpXmlFileReader.java:import
> org.jdom.Element;
> ./modules/unsupported/shapefile-old/src/main/java/org/geotools/data/shapefile/shp/xml/ShpXmlFileReader.java:import
> org.jdom.input.SAXBuilder;
> ./modules/unsupported/shapefile-old/src/main/java/org/geotools/data/shapefile/shp/xml/ShpXmlFileReader.java:import
> org.jdom.JDOMException;
>
>
> So I'm wondering... shall we just drop it instead of upgrading it? I hear
> JDOM API is nicer to use though.
> Anyways, don't take this too seriously, mostly curiosity on my part
>
> Cheers
> Andrea
>
> --
> ==
> Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
> information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
>
> ------------------------------------------------------------------------------
> Introducing Performance Central, a new site from SourceForge and
> AppDynamics. Performance Central is your source for news, insights,
> analysis and resources for efficient Application Performance Management.
> Visit us today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
>
> _______________________________________________
> GeoTools-Devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
>
> ------------------------------------------------------------------------------
> Introducing Performance Central, a new site from SourceForge and
> AppDynamics. Performance Central is your source for news, insights,
> analysis and resources for efficient Application Performance Management.
> Visit us today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
> _______________________________________________
> GeoTools-Devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis and resources for efficient Application Performance Management.
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
