On Sat, Sep 28, 2013 at 2:57 PM, Andrea Aime
<[email protected]>wrote:
> Hi,
> today I've setup that JDK 7 Travis build I was talking about some time
> ago, it builds
> with both OpenJDK and Oracle JDK 7:
> https://travis-ci.org/geotools/geotools
>
> As you can see it's working on OpenJDK, and failing on Oracle JDK.
> The thing is, afaik, mostly accidental, the real issue is that the first
> H2 test run in the
> failing build is H2EmptyGeometryTest, and it's easily reproduced by doing
> the following:
> * go to jdbc-h2/target, wipe out the geotools database files
> * run the test, it will break on any platform/jdk
>
> The issue is that the "geotools" catalog does not exist, the
> H2EmptyGeometryTestSetup
> will not create it, and yet it assumes it's there.
>
> Now, this is partly my fault, some time ago I proposed to avoid having the
> JDBCDelegatingTestSetup
> avoid running the wrapped test setup own table creation/deletion scripts.
> While I did so for a good reason, why do we have to create and drop ft1
> and ft2 over and over
> for tests that are not using them, it's the cause of this failure, because
> the H2TestSetup
> _does_ create the "geotools" catalog.
>
> Now, I could revert that change, but it would also revert the benefit we
> have in all other
> databases.
> Or I could have each H2 test create and drop the "geotools" catalog, which
> would duplicate
> some code.
>
Agreed, it would be nice not to revert.
>
> Or maybe change the code so that there is a "inheritable" setup/teardown
> phase that
> we have the JDBCDelegatingTestSetup run from its delegate, and put the
> schema
> creation/deletion there
>
So two sets of teardown/setup? One that would be run once? And one that
would be run every test?
>
> Opinions?
>
> Cheers
> Andrea
>
> --
> ==
> Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
> information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
> _______________________________________________
> GeoTools-Devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
--
*Justin Deoliveira*
Vice President, Engineering | Boundless
[email protected]
@j_deolive <https://twitter.com/j_deolive>
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
