Jody:
Let me follow up with the programmer to see if they will help me maintain
the module. If they are interested in doing this, we will try to get the
thing unit tested and then perhaps it can be added as a supported module.
Landon
On Thu, Oct 10, 2013 at 1:59 PM, Jody Garnett <jody.garn...@gmail.com>wrote:
> So the pull request is here:
> - https://github.com/geotools/geotools/pull/189
>
> Looks like we just wait conformation from a board member that sosimple has
> sent in a contribution agreement. In cases like this where the module is
> unsupported, I try to ask if they are interested in volunteering to become
> module maintainer.
>
> It is a bit more work, they need to ask for commit access - the benifit is
> a chance to help others (and review future changes to a module they
> obviously use).
>
> Jody Garnett
>
>
> On Fri, Oct 11, 2013 at 2:02 AM, Landon Blake <
> sunburned.surve...@gmail.com> wrote:
>
>> There is currently a pull request on the DXF module to add support for
>> "extended data". I completed a brief review of the pull request today, and
>> I had the programmer answer some questions about his changes to the code.
>>
>> I don't have an intimate knowledge of the DXF module, but the programmers
>> changes look OK to me. He is also using the revised code in production at
>> his organization.
>>
>> Please note: The DXF module doesn't have any unit tests, and no unit
>> tests were added or modified as part of this change.
>>
>> I believe this is an unsupported module, so I'd recommend we accept this
>> pull request. If the DXF module doesn't have a maintainer, I will try to
>> fill this role. I'd like to make time in November to get to know the code
>> in the module and to start writing unit tests for it.
>>
>> Please share your comments.
>>
>> I won't be able to accept the pull request, as I don't have those
>> permission in GitHub.
>>
>> Thanks.
>>
>> Landon
>>
>>
>> ------------------------------------------------------------------------------
>> October Webinars: Code for Performance
>> Free Intel webinars can help you accelerate application performance.
>> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
>> from
>> the latest Intel processors and coprocessors. See abstracts and register >
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
>> _______________________________________________
>> GeoTools-Devel mailing list
>> GeoTools-Devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>>
>
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
