Looked over your patches Jared, they look good to me for the most part. I
had one comment about the georss pull request.

As for using the bridj stuff on mac I too have had problems with it, with
gdal and other libraries as well. I have unfortunately never been able to
get it to run reliably. That said I haven't tried the newest version for
the ogr datastore for quite some time.

On Thu, Jan 2, 2014 at 12:24 AM, Andrea Aime
<[email protected]>wrote:

> On Thu, Jan 2, 2014 at 12:51 AM, Jared Erickson 
> <[email protected]>wrote:
>
>> Hi all,
>>
>> I have been working on adding OGR support to GeoScript and in my testing
>> I found a couple of bugs and added a few improvements.  I just added six
>> JIRA issues and sent six pull requests.  The order is somewhat important.
>>  1 and 2 are just bug fixes to get the unit tests passing.  3, 4 and 5 add
>> tests for various formats and changes required to make them run.  A bug fix
>> in #3 (Bridj support for String arrays) is required for 4 and 5 because
>> OGR Layer options won’t work in the Bridj module without it.  #6 is just
>> my attempt to make it easier to unit test these modules which require
>> native libraries.
>>
>> 1. Fix Bridj unit test. The overridden setup methods needs to call super.
>>    GEOT-4650
>>    https://github.com/geotools/geotools/pull/332
>>
>> 2. Fix failing unit test. Call getTypeName because Name includes the
>> namespace
>>    GEOT-4651
>>    https://github.com/geotools/geotools/pull/333
>>
>> 3. Add unit test for reading and writing GeoRSS.
>>    GEOT-4652
>>    https://github.com/geotools/geotools/pull/334
>>
>> 4. Add unit test for reading the writing SQLite.
>>    GEOT-4653
>>    https://github.com/geotools/geotools/pull/335
>>
>> 5. Add unit tests for writing and reading several formats:
>>    GEOT-4654
>>    https://github.com/geotools/geotools/pull/336
>>
>> 6. Add environmental variables to the maven surefire plugin to make it
>> easier
>>    GEOT-4655
>>    https://github.com/geotools/geotools/pull/337
>>
>> All of the tests pass on my Windows box and in my Ubuntu 12 VM.  The
>> ogr-jni tests pass on my Mac but ogr-bridj just segfaults.  I haven’t been
>> able to figure out why.
>>
>
> Hi Jared,
> that's great, I'll try to have a look soon.
> About segfaults on Mac, have you tried upgrading to the latest version of
> Bridj? Does that help any?
>
> Cheers
> Andrea
>
> --
> *== GeoSolutions will be closed for seasonal holidays from 23/12/2013 to
> 06/01/2014 ==*
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054  Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39  339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
>
> ------------------------------------------------------------------------------
> Rapidly troubleshoot problems before they affect your business. Most IT
> organizations don't have a clear picture of how application performance
> affects their revenue. With AppDynamics, you get 100% visibility into your
> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics
> Pro!
> http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
> _______________________________________________
> GeoTools-Devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>


-- 
*Justin Deoliveira*
Vice President, Engineering | Boundless
[email protected]
@j_deolive <https://twitter.com/j_deolive>
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to