One more glitch (caused by removing the GeoTools Filter and Expression
classes).
FilterToSQL visitBinarySpatialOperator was checking (and casting
BinaryCompareOperator). The two types are no longer linked by an accident
of implementation so the method now uses BinarySpatialOperator for access
to getExpression1() and getExperssion2() methods.
Jody Garnett
On Wed, Apr 30, 2014 at 8:16 AM, Jody Garnett <[email protected]>wrote:
> As per the meeting minuets I need to ask for a volunteer to review this
> pull request. Ideally before the weekend as I do not want to see this
> (extensive) patch undergo bit rot :)
>
> There are two options for review:
> a) As it stands the commits form a clear progression of cleaning up
> interfaces, deleting methods and then removing unused classes
> b) Or checkout the branch and squash things down to one commit
>
> It is all fairly mechanical, here are three interesting things:
>
> a) BBoxExpression (which has been removed) converted an Envelope into a
> clockwise polygon. JTS.toGeometry(Envelope) produces a counter-clockwise
> polygon and could not be used as a replacement.
>
> b) The Literal implementation ConstantExpression could not be removed as
> it used by the style classes, in a similar fashion OverlapBehavior could
> not be removed as it is used by StyleVisitor
>
> c) Everything has been migrated to FilterFactory ... except for the SAX
> Parsers which now uses the implementation classes directly
>
>
> Jody Garnett
>
>
> On Mon, Apr 28, 2014 at 12:23 PM, Jody Garnett <[email protected]>wrote:
>
>> I decided to keep Andrea company by working on our technical debt[1] -
>> thanks to GEOT-4785.
>>
>> While my last pull request was interesting, this one is extensive:
>>
>> - https://github.com/geotools/geotools/pull/434
>>
>> Please see the pull request for full description. While this pull request
>> does not fix everything it removes a lot of "casual" excuses for a class
>> cast exception including use of the old Filter methods and FilterVisitor /
>> FilterVisitor2 classes.
>>
>> GeoServer works without change after this pull request.
>> --
>> Jody Garnett
>> [1]
>> http://docs.codehaus.org/display/GEOTOOLS/Remove+Assumption+of+org.geotools.filter.Filter
>>
>
>
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos. Get
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
