Sounds good:)

I've got a branch of our codebase set up to verify some use cases when its backported into 11.x

I know that 11.1 just came out...any idea when the 11.2 release might be out?

I think I'm going to try to pull down that patch on a local 11.x branch and try it out now though with that commit patched in.

Thanks!

Andrew

On 06/24/2014 11:55 PM, Jody Garnett wrote:
I think you asked on the devel list - something along the lines of "this has been available on master for a month" any objects to back porting it to 11.x :)

Since it has been a month, and it is not right before the 11.2 release we should be good.

So for reference this fixes a few ECQL encoding / decoding issues (but not all of them). In addition to "fixing" the representation of FeatureId in an IN filter (GEOT-4783 <https://jira.codehaus.org/browse/GEOT-4783>):

IN (river.1,river.2) should not be used, the correct representation is IN ('river.1','river.2')

This change recognises the OR encoding of an IN statement used to check attributes along with a few other special cases.

When it recognises a special case the ECQL notation will be used rather than the plain CQL OR representation

Example: if you are just testing numbers you can use x IN (1,2,3)

The is an alternative to: x = 1 OR x = 2 OR x =3

I also messed with brackets a bit so they are only used in the event of nested logical expressions, the alternative would be (x = 1) OR (x=2) OR (x=3)

This work is available on a single commit: https://github.com/geotools/geotools/commit/649853a304a4779ed86121151193ea0fe049f367

Comment on April 30th: "Resolved on master, will back port to stable if it lasts the month"
--
Jody


Jody Garnett


On Wed, Jun 25, 2014 at 9:35 AM, Andrew Hulbert <[email protected] <mailto:[email protected]>> wrote:

    Looks like it was not backported yet when comparing this file
    (specifically line 116) on 11.x branch versus master:

    
https://github.com/geotools/geotools/blob/11.x/modules/library/cql/src/main/java/org/geotools/filter/text/ecql/FilterToECQL.java


    That's one still causing a ClassCastException.

    Let me know what the process is to get it backported.

    Thanks for taking a look.

    Andrew


    On 06/24/2014 06:38 PM, Jody Garnett wrote:
    I cannot remember if I back ported it or not - however I do not
    know of any reason why it cannot be taken across (the changes
    were pretty limited).

    jody

    Jody Garnett


    On Tue, Jun 24, 2014 at 10:24 PM, Andrew Hulbert
    <[email protected] <mailto:[email protected]>> wrote:

        Jody,

        Finally getting back around to this...

        Just wondering if its possible to get a backport of
        https://github.com/geotools/geotools/pull/431 to the 11.x branch?

        I might be have time in a few weeks to reformat it and test
        it against
        11.x but figured I'd ask first!

        Thanks,

        Andrew

        
------------------------------------------------------------------------------
        Open source business process management suite built on Java
        and Eclipse
        Turn processes into business applications with Bonita BPM
        Community Edition
        Quickly connect people, data, and systems into organized
        workflows
        Winner of BOSSIE, CODIE, OW2 and Gartner awards
        http://p.sf.net/sfu/Bonitasoft
        _______________________________________________
        GeoTools-Devel mailing list
        [email protected]
        <mailto:[email protected]>
        https://lists.sourceforge.net/lists/listinfo/geotools-devel





------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to