Ciao Jody,
Sorry for delay in replying,
I wrote the geoserver doc you suggest and I committed it in the master
branch https://github.com/geoserver/geoserver/pull/644 .
I did also the backport of the new pool params in the 11.x geotools branch
https://github.com/geotools/geotools/pull/502 .
If something is not clear or for anything else about these pull requests,
I'm available for further clarifications or fixes.
Regards,
Damiano
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.
==
Dott. Damiano Giampaoli
Software Engineer
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 962313
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
2014-07-12 2:23 GMT+02:00 Jody Garnett <[email protected]>:
> Merged onto geotools master, still hoping to see some docs for the
> geoserver project (when you get a chance).
>
> Jody Garnett
>
>
> On Wed, Jul 9, 2014 at 11:04 AM, Jody Garnett <[email protected]>
> wrote:
>
>> Excellent I will look forward to your revised pull request, and thanks
>> for escalating this on the devel list.
>> --
>> Jody
>>
>> Jody Garnett
>>
>>
>> On Wed, Jul 9, 2014 at 9:07 AM, Damiano Giampaoli <
>> [email protected]> wrote:
>>
>>>
>>> Ciao Jody,
>>> read my answers below,
>>>
>>>
>>> Regards,
>>> Damiano
>>>
>>>
>>> 2014-07-08 20:08 GMT+02:00 Jody Garnett <[email protected]>:
>>>
>>> So yeah, for new parameters (i.e. API change) can you add an example to
>>>> the docs?
>>>>
>>>>
>>> sure
>>>
>>>
>>>> * http://docs.geotools.org/latest/userguide/library/jdbc/datastore.html
>>>>
>>>> If you do have a story to tell with a firewall perhaps you could use it
>>>> as an example for the GeoServer docs?
>>>>
>>>> *
>>>> http://docs.geoserver.org/stable/en/user/data/database/connection-pooling.html
>>>>
>>>
>>> yes
>>>
>>>
>>>>
>>>> A couple of scheduling questions for you?
>>>>
>>>> Q: From the gs/gt meeting this is one of the features expected before
>>>> the feature freeze? Are you able to add the docs this week?
>>>>
>>>
>>> yes, I'll add the documentation commits to the existing pull request
>>> within tomorrow morning... is it still in time for the feature freeze right?
>>>
>>>
>>>> Q: Are you wanting to back port this to the GeoTools 11.2 release
>>>> next week?
>>>>
>>>>
>>>>
>>> Yes, I'll make another pull request as soon as possible
>>>
>>>
>>>>
>>>>
>>>> Jody Garnett
>>>>
>>>>
>>>> On Tue, Jul 8, 2014 at 10:07 AM, Damiano Giampaoli <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi all,
>>>>>
>>>>> I submitted a pull request regarding the connection pool
>>>>> configuration. https://github.com/geotools/geotools/pull/501
>>>>> The pull request is quite small and simple, only the class
>>>>> JDBCDataStoreFactory.java class is involved.
>>>>>
>>>>> Motivations of the pull request:
>>>>> We have experienced some trouble in several production geoserver
>>>>> installations that make the geoserver datastores connected to a DBMS
>>>>> unavailable usually for 10-15 minutes.
>>>>> We discovered that this happens when in the middle of geoserver and
>>>>> the database there is a firewall (or something similar) configured to
>>>>> delete idle tcp connections.
>>>>> If a pool underlying TCP connection is deleted the validation query
>>>>> can take several minutes to be executed and it basically blocks all
>>>>> requests to the layers.
>>>>>
>>>>> Proposed fix:
>>>>> As has been discussed in the past, the usage of apache commons DBCP2
>>>>> can best address this kind of problems but its migration can be tricky. In
>>>>> the meanwhile the patch I submitted allows to perform further
>>>>> configurations in order to solve this kind of issues.
>>>>>
>>>>> These are the new parameters introduced in this pull request:
>>>>>
>>>>> TEST_WHILE_IDLE = If IDLE connections should be validated before
>>>>> using them
>>>>> TIME_BETWEEN_EVICTOR_RUNS = Idle object evictor periodicity
>>>>> MIN_EVICTABLE_TIME = Min time for a connection to be idle in order to
>>>>> be evicted
>>>>> EVICTOR_TESTS_PER_RUN = Number of connections checked during a single
>>>>> evictor run
>>>>>
>>>>> Playing a bit with these 4 parameters has successfully solved the
>>>>> idle connection issue in 3 our different geoserver installations.
>>>>>
>>>>>
>>>>> Looking forward for your opinion, I'm available for further
>>>>> explanations
>>>>>
>>>>> Best regards,
>>>>> Damiano
>>>>>
>>>>>
>>>>>
>>>>> ==
>>>>> GeoServer Professional Services from the experts! Visit
>>>>> http://goo.gl/NWWaa2 for more information.
>>>>> ==
>>>>>
>>>>> Dott. Damiano Giampaoli
>>>>> Software Engineer
>>>>>
>>>>> GeoSolutions S.A.S.
>>>>> Via Poggio alle Viti 1187
>>>>> 55054 Massarosa (LU)
>>>>> Italy
>>>>> phone: +39 0584 962313
>>>>> fax: +39 0584 962313
>>>>>
>>>>> http://www.geo-solutions.it
>>>>> http://twitter.com/geosolutions_it
>>>>>
>>>>> -------------------------------------------------------
>>>>>
>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> Open source business process management suite built on Java and Eclipse
>>>>> Turn processes into business applications with Bonita BPM Community
>>>>> Edition
>>>>> Quickly connect people, data, and systems into organized workflows
>>>>> Winner of BOSSIE, CODIE, OW2 and Gartner awards
>>>>> http://p.sf.net/sfu/Bonitasoft
>>>>> _______________________________________________
>>>>> GeoTools-Devel mailing list
>>>>> [email protected]
>>>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>>>>
>>>>>
>>>>
>>>
>>
>
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck®
Code Sight™ - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
