Niels, I agree with both (1) (but need Jody's advice on this) and (2). It should not be necessary for wfs-ng to depend on app-schema. It may be possible to refactor app-schema to use common code in gt-main and gt-complex to avoid duplication.
Kind regards, Ben. On 13/03/15 23:45, Niels Charlier wrote: > Hello Ben, > > I have had a look at this work. There is already quite some need for > manual merging to get this to work, because a lot has changed in the > meantime. At this moment I have two main concerns for merge: > > (1) The changes regarding AbstractDataStoreFactory and the new > AbstractDataAccessFactory. In the meantime the class > AbstractDataStoreFactory has been deprecated and wfs-ng does not depend > on it any longer (it is an immediate implementation of the factory > interface), I understand ContentDataStore has taken over some of its > functionality (?). I have a suspicion that the creation of a new > AbstractDataAccessFactory has become unnecessary and this will probably > need to be removed from the pr. > > I have CCd Jody for this purpose, @Jody, would you pretty please check > out only what happens with AbstractDataStoreFactory in this pr > specifically (no need to check anything else but gt-main changes) and > give your recommendation on what to do with this? > > (2) I am wondering if it is really necessary to let wfs-ng depend on > app-schema. We have created gt-complex to avoid this. I checked what it > is using from app-schema and it is the AppSchemaFeatureTypeRegistry and > EmfAppSchemaReader. We have made the more general FeatureTypeRegistry > and EmfComplexFeatureReader in gt-complex for general xsd-based complex > feature creation, the difference is that app-schema injects the GML > libraries into these (CSW uses non-gml complex features). I wonder if it > isn't even a better idea copy-paste the GML-injection code into wfs-ng > (:( ), because it is a bit absurd to force the dependency of the whole > app-schema module in wfs-ng only for this?? Opinions? > > Kind Regards > Niels > > On 03-02-15 20:11, Ben Caradoc-Davies wrote: >> Niels and Sampo, >> >> have you seen Rini's complex feature parsing pull request? This >> resurrects Adam Brown's GML client library work. Discussion and links >> here: >> https://github.com/geotools/geotools/pull/406 >> >> We were discussing this at the committee meeting and wondered if you >> or anyone else had an opinion. I think Niels you used and improved >> some of Adam's original changes to app-schema (caching and the new >> gt-complex module). There are some changes in wfs-ng as well. Rini has >> done most of the work. >> >> Rini waited patiently and is now on extended leave. It would be great >> if this could be merged before she gets back. On master, after the >> feature freeze. >> >> Kind regards, >> > > > -- Ben Caradoc-Davies <[email protected]> Software Engineer Transient Software <http://transient.nz> New Zealand ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
