Since my first idea of using a prepared statement would not be popular, are
you proposing we recognizing java.sql.Date (and use that directly with
toString()) or do we need to introduce a dialect for each database?
This may also cover the case of java.util.Date case (it would go to sql
date and then out through a database dialect).
--
Jody Garnett
On 13 March 2015 at 14:35, Andrea Aime <[email protected]> wrote:
> Hi,
> today we are trying to run some cite tests as an exercise to teach people
> how to do so,
> and to my surprise, the wfs 1.0 tests are failing on my machine, which is
> still on
> european timezone.
>
> So we have a wfs request looking like this:
>
>
> http://localhost:8081/geoserver/wfs?request=GetFeature&service=WFS&version=1.0.0&request=GetFeature&outputformat=GML2&typename=cdf:Other&filter=<ogc:Filter
> xmlns:ogc="http://www.opengis.net/ogc"; xmlns:cdf="
> http://www.opengis.net/cite/data
> "><ogc:PropertyIsLessThan><ogc:PropertyName>cdf:dates</ogc:PropertyName><ogc:Literal>2002-12-03</ogc:Literal></ogc:PropertyIsLessThan></ogc:Filter>
>
> Inside the FilterToSQL the "2002-12-03" gets turned into a java.sql.Date
> inside FilterToSql.visit(Literal expression, Object context),
> to match the property type. So far, good, it gets turned into a
> "2002-12-03" java.sql.Date object.
> And then we enter into FilterToSql.writeLiteral method, which does not
> know what to make of the java.sql.Date and calls
> onto Converters again, asking a conversion to String... and here, at least
> on my machine, XMLConverterFactory does
> the conversion, switching the date to GMT:
>
> Calendar cal =
> Calendar.getInstance(TimeZone.getTimeZone("GMT"));
> cal.setTimeInMillis(((java.util.Date)
> unconvertedValue).getTime());
> DatatypeConverterImpl converter =
> DatatypeConverterImpl.getInstance();
>
> and here it becomes 2002-12-02 23:00, we convert this to string under a
> "only date" model
> and boom, it becomes 2002-12-02Z, we lost a day (and the test fails).
>
> It seems wrong that we end up using a xml specific converter in a sql
> context... Maybe we should
> do a manual conversion for dates instead of relying on converters?
>
> I'm going to try and whip up a pull request going this direction
>
> Cheers
> Andrea
>
> --
> ==
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/NWWaa2 for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
>
> Le informazioni contenute in questo messaggio di posta elettronica e/o
> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
> darcene notizia via e-mail e di procedere alla distruzione del messaggio
> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
> principi dettati dal D.Lgs. 196/2003.
>
>
>
> The information in this message and/or attachments, is intended solely for
> the attention and use of the named addressee(s) and may be confidential or
> proprietary in nature or covered by the provisions of privacy act
> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
> Code).Any use not in accord with its purpose, any disclosure, reproduction,
> copying, distribution, or either dissemination, either whole or partial, is
> strictly forbidden except previous formal approval of the named
> addressee(s). If you are not the intended recipient, please contact
> immediately the sender by telephone, fax or e-mail and delete the
> information in this message that has been received in error. The sender
> does not give any warranty or accept liability as the content, accuracy or
> completeness of sent messages and accepts no responsibility for changes
> made after they were sent or for other risks which arise as a result of
> e-mail transmission, viruses, etc.
>
> -------------------------------------------------------
>
>
> ------------------------------------------------------------------------------
> Dive into the World of Parallel Programming The Go Parallel Website,
> sponsored
> by Intel and developed in partnership with Slashdot Media, is your hub for
> all
> things parallel software development, from weekly thought leadership blogs
> to
> news, videos, case studies, tutorials and more. Take a look and join the
> conversation now. http://goparallel.sourceforge.net/
> _______________________________________________
> GeoTools-Devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
