Hi,
I'm looking at logs and info from a GeoServer installation that's taking a
lot
of time to display the layer list.
As far as I can see, all the time is spend in createTypeNames(), being
called
by entry(name), and the code I'm seeing gives me pause:
final protected ContentEntry entry(Name name) throws IOException {
ContentEntry entry = null;
boolean found = entries.containsKey(name);
if (!found && name.getNamespaceURI() == null
&& this.namespaceURI != null) {
Name defaultNsName = new NameImpl(namespaceURI,
name.getLocalPart());
if (entries.containsKey(defaultNsName)) {
name = defaultNsName;
found = true;
}
}
// try a namespace-less match (createTypeNames() can be expensive,
we leave it as last
// resort)
if (!found) {
List<Name> typeNames = createTypeNames();
found = typeNames.contains(name);
if (!found && name.getNamespaceURI() == null) {
for (Name typeName : typeNames) {
if
(typeName.getLocalPart().equals(name.getLocalPart())) {
name = typeName;
found = true;
break;
}
}
}
}
if (found) {
// yes, create an entry for it
synchronized (this) {
if (!entries.containsKey(name)) {
entry = new ContentEntry(this, name);
entries.put(name, entry);
}
}
entry = entries.get(name);
}
return entries.get(name);
}
In other terms, every time we create a new content entry, we call
createTypeNames(),
which in turn lists all the possible tables (in a JDBCDataStore).
Wouldn't it make sense, once we do that, to create ContentEntry for all
type names, to
avoid having to call back createTypeNames() for each new table we're
listing?
I guess this is similar to the type caching mechanism Jody was proposing in
a pull
request that got revert, but at least does not suffer from ignoring newly
created tables.
Cheers
Andrea
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
