On 13/04/15 01:07, Andrea Aime wrote:
> Basically I would switch the test to simply:
> if (available == null || available.booleanValue()) { << here!
> This way once "available" has been set, we stay that way for the rest of
> the test.
That looks unchanged to me. You mean change this test to the following?:
if (available == null) {
That looks like it might fix the problem in this case.
I would be happier if we made an even more brutal refactoring: a test
with a fixture always runs; the *OnlineTest name pattern is used to turn
on some classes with -Ponline. No more silent failures. Rip out the
entire isOnline / skipOnFailure infrastructure.
This class (and I acknowledge my involvement in helping us to reach this
point) conflates two orthogonal concerns: (1) classes that require an
external fixture configuration, and (2) classes that require an online
resource. In my view, it should handle only (1) and permit (2) to be
handled by class naming. The class could renamed FixtureTestCase (and
FixtureTestSupport).
I am not even sure that we need a distinction for online tests; could we
not have a rule that tests that use online resources must have a fixture
configuration file? Or perhaps *OnlineTest classes are for tests that
use online resources but require no configuration, to avoid unnecessary
empty fixture files (like SchemaCacheOnlineTest and
schema-resolver.properties)?
In my view, if I configure a test, I want it to run, and fail if it
cannot, rather than silently disabling itself. I think that the current
fixture infrastructure is much more complicated than it needs to be, is
fragile, and has behaviour that surprises developers.
Kind regards,
--
Ben Caradoc-Davies <[email protected]>
Director
Transient Software Limited <http://transient.nz>
New Zealand
------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
